Skip to content

Commit

Permalink
lint fix
Browse files Browse the repository at this point in the history
  • Loading branch information
csouchet committed Oct 7, 2024
1 parent 0d2d373 commit a708e78
Show file tree
Hide file tree
Showing 8 changed files with 12 additions and 12 deletions.
2 changes: 1 addition & 1 deletion dev/ts/pages/diagram-navigation.ts
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ function configureZoomDebounceInput(parameters: URLSearchParams): HTMLInputEleme
}

function start(): void {
const parameters = new URLSearchParams(window.location.search);
const parameters = new URLSearchParams(globalThis.location.search);
configureMousePointer(parameters);
configureControlsPanel(parameters);

Expand Down
2 changes: 1 addition & 1 deletion dev/ts/pages/overlays.ts
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ function configureRemoveAllOverlays(): void {
}

function start(): void {
const parameters = new URLSearchParams(window.location.search);
const parameters = new URLSearchParams(globalThis.location.search);
configureMousePointer(parameters);
configureControlsPanel(parameters);

Expand Down
2 changes: 1 addition & 1 deletion dev/ts/shared/internal-helpers.ts
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ export function logStartup(message?: string, ...optionalParameters: unknown[]):

export function logErrorAndOpenAlert(error: string, alertMessage?: string): void {
logError(error);
window.alert(alertMessage ?? error);
globalThis.alert(alertMessage ?? error);
}

export function logError(error: string): void {
Expand Down
4 changes: 2 additions & 2 deletions dev/ts/shared/main.ts
Original file line number Diff line number Diff line change
Expand Up @@ -309,7 +309,7 @@ export function startBpmnVisualization(config: BpmnVisualizationDemoConfiguratio
const log = logStartup;
log(`Initializing BpmnVisualization with container:`, config.globalOptions.container);

const parameters = new URLSearchParams(window.location.search);
const parameters = new URLSearchParams(globalThis.location.search);
const rendererIgnoreBpmnColors = parameters.get('renderer.ignore.bpmn.colors');
if (rendererIgnoreBpmnColors) {
const ignoreBpmnColors = rendererIgnoreBpmnColors === 'true';
Expand All @@ -320,7 +320,7 @@ export function startBpmnVisualization(config: BpmnVisualizationDemoConfiguratio

bpmnVisualization = new ThemedBpmnVisualization(config.globalOptions);
log('Initialization completed');
new DropFileUserInterface(window, 'drop-container', bpmnVisualization.graph.container, readAndLoadFile);
new DropFileUserInterface(globalThis, 'drop-container', bpmnVisualization.graph.container, readAndLoadFile);

Check failure on line 323 in dev/ts/shared/main.ts

View workflow job for this annotation

GitHub Actions / demo_preview

Argument of type 'typeof globalThis' is not assignable to parameter of type 'Window'.
log('Drag&Drop support initialized');

statusKoNotifier = config.statusKoNotifier ?? logOnlyStatusKoNotifier;
Expand Down
8 changes: 4 additions & 4 deletions src/component/mxgraph/initializer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -68,11 +68,11 @@ declare global {
function initialize(): mxGraphExportObject {
// set options globally, as it is not working when passing options to the factory (https://github.com/jgraph/mxgraph/issues/479)
// Required otherwise 'Uncaught ReferenceError: assignment to undeclared variable mx...'
window.mxForceIncludes = false;
window.mxLoadResources = false;
globalThis.mxForceIncludes = false;

Check failure on line 71 in src/component/mxgraph/initializer.ts

View workflow job for this annotation

GitHub Actions / build_and_test_npm_package

Element implicitly has an 'any' type because type 'typeof globalThis' has no index signature.

Check failure on line 71 in src/component/mxgraph/initializer.ts

View workflow job for this annotation

GitHub Actions / demo_preview

Element implicitly has an 'any' type because type 'typeof globalThis' has no index signature.
globalThis.mxLoadResources = false;

Check failure on line 72 in src/component/mxgraph/initializer.ts

View workflow job for this annotation

GitHub Actions / build_and_test_npm_package

Element implicitly has an 'any' type because type 'typeof globalThis' has no index signature.

Check failure on line 72 in src/component/mxgraph/initializer.ts

View workflow job for this annotation

GitHub Actions / demo_preview

Element implicitly has an 'any' type because type 'typeof globalThis' has no index signature.
// Required otherwise we got 'Uncaught ReferenceError: assignment to undeclared variable mx...'
window.mxLoadStylesheets = false;
window.mxResourceExtension = '.txt';
globalThis.mxLoadStylesheets = false;

Check failure on line 74 in src/component/mxgraph/initializer.ts

View workflow job for this annotation

GitHub Actions / build_and_test_npm_package

Element implicitly has an 'any' type because type 'typeof globalThis' has no index signature.

Check failure on line 74 in src/component/mxgraph/initializer.ts

View workflow job for this annotation

GitHub Actions / demo_preview

Element implicitly has an 'any' type because type 'typeof globalThis' has no index signature.
globalThis.mxResourceExtension = '.txt';

Check failure on line 75 in src/component/mxgraph/initializer.ts

View workflow job for this annotation

GitHub Actions / build_and_test_npm_package

Element implicitly has an 'any' type because type 'typeof globalThis' has no index signature.

Check failure on line 75 in src/component/mxgraph/initializer.ts

View workflow job for this annotation

GitHub Actions / demo_preview

Element implicitly has an 'any' type because type 'typeof globalThis' has no index signature.

return factory({});
}
2 changes: 1 addition & 1 deletion src/component/mxgraph/shape/render/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,6 @@ limitations under the License.
*/

// export types first, otherwise typedoc doesn't generate the subsequent doc correctly (no category and uses the file header instead of the actual TSDoc)
export * from './render-types';
export type * from './render-types';
export { BpmnCanvas, type BpmnCanvasConfiguration } from './BpmnCanvas';
export { IconPainter, IconPainterProvider, type PaintParameter } from './icon-painter';
2 changes: 1 addition & 1 deletion src/component/registry/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,5 +15,5 @@ limitations under the License.
*/

// export types first, otherwise typedoc doesn't generate the subsequent doc correctly (no category and uses the file header instead of the actual TSDoc)
export * from './types';
export type * from './types';
export { BpmnElementsRegistry } from './bpmn-elements-registry';
2 changes: 1 addition & 1 deletion src/model/bpmn/json/baseElement/baseElement.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ limitations under the License.

import type { TDataState } from './data';
import type { TExpression, TFormalExpression } from './expression';
import type { TImplicitThrowEvent } from './flowNode/event';
import type { TDocumentation, TExtensionElements } from '../Semantic';
import type { TImplicitThrowEvent } from './flowNode/event';

// abstract="true"
// <xsd:anyAttribute namespace="##other" processContents="lax"/>
Expand Down

0 comments on commit a708e78

Please sign in to comment.