Skip to content

Commit

Permalink
Merge branch 'master' into test/fix_e2e_received_custom_dir
Browse files Browse the repository at this point in the history
  • Loading branch information
tbouffard committed Aug 21, 2024
2 parents f579926 + be46a70 commit efa087f
Show file tree
Hide file tree
Showing 5 changed files with 21 additions and 13 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ jobs:
# No need to run the analysis from all environments
- name: SonarCloud Scan
if: ${{ success() && contains(matrix.os.coverage, 'coverage') && env.SONAR_TOKEN != '' }}
uses: SonarSource/sonarcloud-github-action@v2.3.0
uses: SonarSource/sonarcloud-github-action@v3.0.0
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # Needed to get PR information, if any
SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
12 changes: 10 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,11 @@ import { BpmnVisualization } from 'bpmn-visualization';
// 'bpmn-container' is the id of the HTMLElement that renders the BPMN Diagram
const bpmnVisualization = new BpmnVisualization({ container: 'bpmn-container' });
let bpmnContent; // your BPMN 2.0 XML content
bpmnVisualization.load(bpmnContent);
try {
bpmnVisualization.load(bpmnContent);
} catch (error) {
console.error('Error loading BPMN content', error);
}
```

You can set the BPMN content using one of the following ways:
Expand Down Expand Up @@ -161,7 +165,11 @@ In the HTML page:
// 'bpmn-container' is the id of the HTMLElement that renders the BPMN Diagram
const bpmnVisualization = new bpmnvisu.BpmnVisualization({ container: 'bpmn-container'});
let bpmnContent; // your BPMN 2.0 XML content
bpmnVisualization.load(bpmnContent);
try {
bpmnVisualization.load(bpmnContent);
} catch (error) {
console.error('Error loading BPMN content', error);
}
</script>
```

Expand Down
14 changes: 7 additions & 7 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@
"rollup-plugin-node-externals": "~7.1.2",
"rollup-plugin-sizes": "~1.0.6",
"rollup-plugin-typescript2": "~0.36.0",
"tailwindcss": "~3.4.9",
"tailwindcss": "~3.4.10",
"ts-jest": "~29.2.4",
"typedoc": "~0.25.13",
"typescript": "~5.4.5",
Expand Down
4 changes: 2 additions & 2 deletions src/component/mxgraph/GraphConfigurator.ts
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ import { mxEvent } from './initializer';
export default class GraphConfigurator {
private readonly graph: BpmnGraph;

constructor(readonly container: HTMLElement) {
constructor(container: HTMLElement) {
this.graph = new BpmnGraph(container);
}

Expand Down Expand Up @@ -91,6 +91,6 @@ export default class GraphConfigurator {

function setContainerCursor(graph: BpmnGraph, cursor: 'grab' | 'default'): () => void {
return (): void => {
graph.isEnabled() && (graph.container.style.cursor = cursor);
graph.container.style.cursor = cursor;
};
}

0 comments on commit efa087f

Please sign in to comment.