feat: add link event data in `ShapeBpmnSemantic` #2911

csouchet · 2023-10-03T16:42:32Z

Add new linkEventSourceIds an linkEventTargetId properties in ShapeBpmnSemantic to include data related to the link events that are stored in the internal model.

Closes #2855

github-actions · 2023-10-03T16:43:39Z

♻️ PR Preview 267407d has been successfully destroyed since this PR has been closed.

_{🤖 By surge-preview}

github-actions · 2023-10-03T16:43:48Z

♻️ PR Preview 267407d has been successfully destroyed since this PR has been closed.

_{🤖 By surge-preview}

test/unit/component/parser/json/BpmnJsonParser.event.link.with.source.target.test.ts

tbouffard

ℹ️ This PR is very large so I probably miss some elements. I expected to have one PR for the parsing and another one for enriching the API to make my review easier. Please think about it for the next time (for this one, we can live with the current content).
It covers at least 3 topics which is too much IMHO: parsing (including required refactoring), enrichment of objects returned by APIs, style changes.
✔️ The implementation seems to do the job
❌ Extra style identifiers to be removed as they are not used at all in the rendering code (next time, feel free to contact me in advance)
❌ Various improvements to apply in particular in the test code

docs/users/architecture/images/architecture/internal-model.svg

src/component/mxgraph/renderer/StyleComputer.ts

src/component/registry/types.ts

src/model/bpmn/internal/shape/utils.ts

test/fixtures/bpmn/registry/1-pool-3-lanes-message-start-end-intermediate-events.bpmn

test/integration/model.elements.api.test.ts

test/unit/component/registry/bpmn-model-registry.test.ts

test/integration/dom.bpmn.elements.test.ts

test/unit/component/parser/json/BpmnJsonParser.event.link.with.source.target.test.ts

src/component/registry/types.ts

src/model/bpmn/internal/shape/utils.ts

tbouffard · 2023-10-05T12:01:30Z

test/fixtures/bpmn/registry/1-pool-2-lanes-link-intermediate-events.bpmn

thought: New content OK from the BPMN semantic point of view

…emantic

…ntic.bpmn

# Conflicts: # test/integration/model.elements.api.test.ts

# Conflicts: # test/fixtures/bpmn/registry/1-pool-3-lanes-message-start-end-intermediate-events.bpmn # test/integration/dom.bpmn.elements.test.ts # test/integration/helpers/semantic-with-svg-utils.ts

….bpmn # Conflicts: # test/fixtures/bpmn/registry/1-pool-3-lanes-message-start-end-intermediate-events.bpmn

This reverts commit 10e6f91.

This reverts commit 6ee75d1.

This reverts commit 645a805.

…yle computer update")

sonarqubecloud · 2023-10-13T06:53:37Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

100.0% Coverage
0.0% Duplication

csouchet added enhancement New feature or request depends on another PR ⚠️ Pull request depending on another one. The depending must be merged first labels Oct 3, 2023

csouchet commented Oct 3, 2023

View reviewed changes

test/unit/component/parser/json/BpmnJsonParser.event.link.with.source.target.test.ts Outdated Show resolved Hide resolved

csouchet commented Oct 3, 2023

View reviewed changes

test/unit/component/parser/json/BpmnJsonParser.event.link.with.source.target.test.ts Outdated Show resolved Hide resolved

csouchet added the WIP 🚧 Pull request in progress and/or not ready for review. Used in addition to marking it as draft label Oct 3, 2023

csouchet force-pushed the 2855-link_event_in_BPMN_Semantic_data branch from fd8932a to 3fda80f Compare October 4, 2023 09:17

csouchet removed the depends on another PR ⚠️ Pull request depending on another one. The depending must be merged first label Oct 4, 2023

csouchet force-pushed the 2855-link_event_in_BPMN_Semantic_data branch 6 times, most recently from 1d3a399 to abddef3 Compare October 4, 2023 16:36

csouchet removed the WIP 🚧 Pull request in progress and/or not ready for review. Used in addition to marking it as draft label Oct 4, 2023

csouchet force-pushed the 2855-link_event_in_BPMN_Semantic_data branch from abddef3 to 763f44e Compare October 4, 2023 16:45

csouchet requested a review from tbouffard October 4, 2023 16:45

csouchet marked this pull request as ready for review October 4, 2023 16:46

tbouffard requested changes Oct 5, 2023

View reviewed changes

tbouffard reviewed Oct 5, 2023

View reviewed changes

csouchet marked this pull request as draft October 12, 2023 14:53

csouchet added the depends on another PR ⚠️ Pull request depending on another one. The depending must be merged first label Oct 12, 2023

csouchet force-pushed the 2855-link_event_in_BPMN_Semantic_data branch from 691fa80 to c57a44d Compare October 12, 2023 15:12

tbouffard mentioned this pull request Oct 12, 2023

[INFRA] Review and improve the eslint configuration #2742

Open

23 tasks

csouchet and others added 5 commits October 13, 2023 08:26

Add linkEventSourceIds and linkEventTargetId properties in ShapeBpmnS…

e15dc6f

…emantic

add model registry tests

764600e

Add source and target on link event definition of model-complete-sema…

1272a8d

…ntic.bpmn

Add integration tests for model.elements.api

29abb02

# Conflicts: # test/integration/model.elements.api.test.ts

Add integration tests for dom.bpmn.elements

6da528e

# Conflicts: # test/fixtures/bpmn/registry/1-pool-3-lanes-message-start-end-intermediate-events.bpmn # test/integration/dom.bpmn.elements.test.ts # test/integration/helpers/semantic-with-svg-utils.ts

csouchet and others added 14 commits October 13, 2023 08:31

Add integration tests for mxGraph.model.bpm.element (style)

36eef78

Add unit tests for computeAllBpmnClassNames

52e1662

Add unit tests for computeStyle

7af0749

Add source and target on style

311e0c9

rename intermediateCatchInModel to intermediateCatchEventInModel

6b15eb1

revert change on 1-pool-3-lanes-message-start-end-intermediate-events…

14110d9

….bpmn # Conflicts: # test/fixtures/bpmn/registry/1-pool-3-lanes-message-start-end-intermediate-events.bpmn

introduce new file: 1-pool-2-lanes-link-intermediate-events.bpmn

b40c761

Revert "Add source and target on style"

8f77678

This reverts commit 10e6f91.

Revert "Add unit tests for computeStyle"

8cef56e

This reverts commit 6ee75d1.

Revert "Add unit tests for computeAllBpmnClassNames"

b141246

This reverts commit 645a805.

ShapeBpmnSemantic: order properties + add JSDoc

75308fd

fix unit tests

975d330

fix an integration test (remaining change not removed when revert "st…

4293172

…yle computer update")

fix integration test

267407d

tbouffard force-pushed the 2855-link_event_in_BPMN_Semantic_data branch from 05080a6 to 267407d Compare October 13, 2023 06:49

tbouffard removed the depends on another PR ⚠️ Pull request depending on another one. The depending must be merged first label Oct 13, 2023

tbouffard marked this pull request as ready for review October 13, 2023 07:00

tbouffard approved these changes Oct 13, 2023

View reviewed changes

tbouffard merged commit 3d52258 into master Oct 13, 2023
27 checks passed

tbouffard deleted the 2855-link_event_in_BPMN_Semantic_data branch October 13, 2023 07:01

tbouffard added the BPMN diagram usability Something about the way we can interact with BPMN diagrams label Oct 13, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add link event data in `ShapeBpmnSemantic` #2911

feat: add link event data in `ShapeBpmnSemantic` #2911

csouchet commented Oct 3, 2023 •

edited by tbouffard

Loading

github-actions bot commented Oct 3, 2023 •

edited

Loading

github-actions bot commented Oct 3, 2023 •

edited

Loading

tbouffard left a comment

tbouffard Oct 5, 2023

sonarqubecloud bot commented Oct 13, 2023

feat: add link event data in ShapeBpmnSemantic #2911

feat: add link event data in ShapeBpmnSemantic #2911

Conversation

csouchet commented Oct 3, 2023 • edited by tbouffard Loading

github-actions bot commented Oct 3, 2023 • edited Loading

github-actions bot commented Oct 3, 2023 • edited Loading

tbouffard left a comment

Choose a reason for hiding this comment

tbouffard Oct 5, 2023

Choose a reason for hiding this comment

sonarqubecloud bot commented Oct 13, 2023

feat: add link event data in `ShapeBpmnSemantic` #2911

feat: add link event data in `ShapeBpmnSemantic` #2911

csouchet commented Oct 3, 2023 •

edited by tbouffard

Loading

github-actions bot commented Oct 3, 2023 •

edited

Loading

github-actions bot commented Oct 3, 2023 •

edited

Loading