refactor: simplify shapes registration #3045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The private method that registered the shapes was a pure function, so it had been extracted from the ShapeConfigurator class. The registration code has also been simplified to better reflect a configuration pattern (less explicit calls to the mxGraph registration code).
|
♻️ PR Preview 997ebf6 has been successfully destroyed since this PR has been closed.
🤖 By surge-preview |
|
♻️ PR Preview 997ebf6 has been successfully destroyed since this PR has been closed.
🤖 By surge-preview |
tbouffard
commented
Feb 26, 2024
| @@ -36,47 +38,53 @@ import { ComplexGatewayShape, EventBasedGatewayShape, ExclusiveGatewayShape, Inc | |||
| import { TextAnnotationShape } from '../shape/text-annotation-shapes'; | |||
| import { BpmnStyleIdentifier } from '../style'; | |||
|
|
|||
| const registerShapes = (): void => { | |||
There was a problem hiding this comment.
thought: the shapes are registered in a global state in mxGraph, so bpmn-visualization currently registers the same shapes at every instantiation of the BpmnVisualization class.
We could register the shapes only once.
This is what is done in maxGraph: https://github.com/maxGraph/maxGraph/blob/v0.8.0/packages/core/src/view/cell/register-shapes.ts#L36-L43
|
csouchet
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The private method that registered the shapes was a pure function, so it had been extracted from the ShapeConfigurator class.
The registration code has also been simplified to better reflect a configuration pattern (less explicit calls to the mxGraph registration code).
Notes
Part of initiative including #3041, #3042 and #3043 (more to come).