fix!: generate correct CSS class name for adhoc subprocess #3058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CSS class name associated to the adhoc subprocess was incorrect. It was `bpmn-sub-process-ad_hoc` instead of `bpmn-sub-process-adhoc`. The tests checking the CSS class names were incorrectly written. Test inputs used hard coded string instead of the actual value of the various enum entries. So, they were unable to detect the problem. BREAKING CHANGES: - The CSS class name associated to the adhoc subprocess in the DOM have changed. It was `bpmn-sub-process-ad_hoc` and it is now `bpmn-sub-process-adhoc`. CSS rules and selectors must be updated accordingly. - The value of `ShapeBpmnSubProcessKind.AD_HOC` changed. As it is not intended to be used directly, applications should not be impacted.
tbouffard
commented
Mar 22, 2024
| @@ -132,7 +132,7 @@ export enum ShapeBpmnMarkerKind { | |||
| * @category BPMN | |||
| */ | |||
| export enum ShapeBpmnSubProcessKind { | |||
| AD_HOC = 'ad_hoc', | |||
| AD_HOC = 'adHoc', | |||
There was a problem hiding this comment.
thought: value could be set to adhoc without impact if we prefer to only use lower-case values.
For consistency with other enum values, I would prefer to use a lower-case value.
|
♻️ PR Preview 4fdd8a1 has been successfully destroyed since this PR has been closed.
🤖 By surge-preview |
|
♻️ PR Preview 4fdd8a1 has been successfully destroyed since this PR has been closed.
🤖 By surge-preview |
csouchet
approved these changes
Mar 25, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CSS class name associated to the adhoc subprocess was incorrect. It was
bpmn-sub-process-ad_hocinstead ofbpmn-sub-process-adhoc.The tests checking the CSS class names were incorrectly written. Test inputs used hard coded string instead of the actual value of the various enum entries. So, they were unable to detect the problem.
BREAKING CHANGES:
bpmn-sub-process-ad_hocand it is nowbpmn-sub-process-adhoc. CSS rules and selectors must be updated accordingly.ShapeBpmnSubProcessKind.AD_HOCchanged. As it is not intended to be used directly, no one should be impacted.Notes
Detected in #2756