refactor: reduce code duplicated from mxGraph to override shape canvas #3138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reduces the maintenance (in particular if we want to migrate to maxGraph) and reduces the size of the bundle a bit. The modified code is fully covered by integration tests. This change will also increase the code coverage as some parts of the duplicated mxGraph code includes paths not used by `bpmn-visualization`.
|
♻️ PR Preview 54326ac has been successfully destroyed since this PR has been closed.
🤖 By surge-preview |
|
♻️ PR Preview 54326ac has been successfully destroyed since this PR has been closed.
🤖 By surge-preview |
|
csouchet
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces the maintenance (in particular if we want to migrate to maxGraph) and reduces the size of the bundle a bit.
The modified code is fully covered by integration tests.
This change will also increase the code coverage as some parts of the duplicated mxGraph code includes paths not used by
bpmn-visualization.Notes
This PR continues the work started in #3043 and #3046