refactor!: rename values in ShapeBpmnMarkerKind
#3147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous values included spaces which is not consistent with values in other enums. Use a kebab case and shorten the values. Refactor also the way markers are painted in `BaseActivityShape`: remove the use of the switch in favor of the use of a Map. This makes the implementation consistent with `EventShape`. BREAKING CHANGES: some values in `ShapeBpmnMarkerKind` have changed. Values are not supposed to be used directly, so this change should not have any impact. For applications using such values, replace the value by the of the enum, in particular for: - MULTI_INSTANCE_PARALLEL - MULTI_INSTANCE_SEQUENTIAL
|
🎊 PR Preview 8ad7a72 has been successfully built and deployed to https://process-analytics-bpmn-visualization-js-doc_preview-pr-3147.surge.sh 🕐 Build time: 0.01s
🤖 By surge-preview |
|
🎊 PR Preview 8ad7a72 has been successfully built and deployed to https://process-analytics-bpmn-visualization-js-demo_preview-pr-3147.surge.sh 🕐 Build time: 0.011s
🤖 By surge-preview |
tbouffard
commented
Aug 16, 2024
tbouffard
changed the title
ShapeBpmnMarkerKindShapeBpmnMarkerKind
|
csouchet
approved these changes
Aug 21, 2024
tbouffard
deleted the
refactor/rename_values_ShapeBpmnMarkerKind_multi-instance
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous values related to "multi instance" included spaces which is not consistent with values in other enums.
They now follow the kebab-case convention and their values are shorter.
Refactor also the way markers are painted in
BaseActivityShape: remove the use of the switch in favor of the use of a Map.This makes the implementation consistent with
EventShape.BREAKING CHANGES: some values in
ShapeBpmnMarkerKindhave changed. Values are not supposed to be used directly, so this change should not have any impact. For applications using such values, use the enum directly, in particular for:Notes
Covers #3146