Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps-dev): bump the lint group with 5 updates #3215

Merged
merged 10 commits into from
Nov 18, 2024
11 changes: 11 additions & 0 deletions .eslintrc.cjs
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ module.exports = {
'unicorn/no-new-array': 'off', // In contradiction with unicorn/new-for-builtins: Use `new Array()` instead of `Array()`
'unicorn/no-null': 'off', // We don't know the impact on mxGraph code
'unicorn/no-useless-undefined': 'off', // The "undefined" value is useful where we use it and change some mxGraph code
'unicorn/prefer-global-this': 'off', // We only target the browser, so it is valid to use the window object. In addition, using 'globalThis' require changes in the code.
tbouffard marked this conversation as resolved.
Show resolved Hide resolved
},
overrides: [
// typescript
Expand Down Expand Up @@ -117,6 +118,16 @@ module.exports = {

'@typescript-eslint/restrict-plus-operands': 'error',

// disable the base rule as it can report incorrect errors when using '@typescript-eslint/no-unused-expressions', see https://typescript-eslint.io/rules/no-unused-expressions/#how-to-use
'eslint/no-unused-expressions': 'off',
'@typescript-eslint/no-unused-expressions': [
'error',
{
allowShortCircuit: true,
allowTernary: true,
},
],

// The following lines are commented, because they show errors on files other than the demo:
// '@typescript-eslint/no-base-to-string': 'error',
// '@typescript-eslint/no-unsafe-assignment': 'error',
Expand Down
488 changes: 226 additions & 262 deletions package-lock.json

Large diffs are not rendered by default.

10 changes: 5 additions & 5 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -119,8 +119,8 @@
"@types/debug": "~4.1.12",
"@types/jest-image-snapshot": "~6.4.0",
"@types/minimist": "~1.2.5",
"@typescript-eslint/eslint-plugin": "~7.18.0",
"@typescript-eslint/parser": "~7.18.0",
"@typescript-eslint/eslint-plugin": "~8.14.0",
"@typescript-eslint/parser": "~8.14.0",
"autoprefixer": "~10.4.20",
"clipboardy": "~4.0.0",
"cross-env": "~7.0.3",
Expand All @@ -130,12 +130,12 @@
"eslint-config-prettier": "~9.1.0",
"eslint-import-resolver-typescript": "~3.6.3",
"eslint-plugin-import": "~2.31.0",
"eslint-plugin-jest": "~28.8.3",
"eslint-plugin-jest": "~28.9.0",
"eslint-plugin-jest-extended": "^2.4.0",
"eslint-plugin-notice": "~1.0.0",
"eslint-plugin-playwright": "~1.7.0",
"eslint-plugin-playwright": "~2.0.1",
"eslint-plugin-prettier": "~5.2.1",
"eslint-plugin-unicorn": "~55.0.0",
"eslint-plugin-unicorn": "~56.0.0",
"expect-playwright": "~0.8.0",
"fs-extra": "~11.2.0",
"husky": "~9.1.6",
Expand Down
2 changes: 1 addition & 1 deletion src/component/mxgraph/shape/render/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,6 @@ limitations under the License.
*/

// export types first, otherwise typedoc doesn't generate the subsequent doc correctly (no category and uses the file header instead of the actual TSDoc)
export * from './render-types';
export type * from './render-types';
export { BpmnCanvas, type BpmnCanvasConfiguration } from './BpmnCanvas';
export { IconPainter, IconPainterProvider, type PaintParameter } from './icon-painter';
2 changes: 1 addition & 1 deletion src/component/registry/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,5 +15,5 @@ limitations under the License.
*/

// export types first, otherwise typedoc doesn't generate the subsequent doc correctly (no category and uses the file header instead of the actual TSDoc)
export * from './types';
export type * from './types';
export { BpmnElementsRegistry } from './bpmn-elements-registry';
9 changes: 3 additions & 6 deletions src/model/bpmn/json/Semantic.ts
Original file line number Diff line number Diff line change
Expand Up @@ -28,15 +28,12 @@ export interface TExtension {
}

// <xsd:any namespace="##other" processContents="lax" minOccurs="0" maxOccurs="unbounded" />
// eslint-disable-next-line @typescript-eslint/no-empty-interface
export interface TExtensionElements {}
export type TExtensionElements = object;

// mixed="true"
// <xsd:any namespace="##any" processContents="lax" minOccurs="0"/>
// eslint-disable-next-line @typescript-eslint/no-empty-interface
export interface TScript {}
export type TScript = object;

// mixed="true"
// <xsd:any namespace="##any" processContents="lax" minOccurs="0"/>
// eslint-disable-next-line @typescript-eslint/no-empty-interface
export interface TText {}
export type TText = object;
6 changes: 5 additions & 1 deletion test/bundles/.eslintrc.cjs
Original file line number Diff line number Diff line change
Expand Up @@ -15,5 +15,9 @@ limitations under the License.
*/

module.exports = {
extends: ['plugin:playwright/jest-playwright'],
extends: ['plugin:playwright/recommended'],
rules: {
/* This rule is for playwright-test and we are using jest-playwright */
'playwright/no-standalone-expect': 'off',
},
};
3 changes: 2 additions & 1 deletion test/config/jest.retries.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@ limitations under the License.
*/

// eslint-disable-next-line @typescript-eslint/ban-ts-comment
// @ts-ignore js file with commonjs export
// @ts-ignore use a shared js file with commonjs export
// eslint-disable-next-line @typescript-eslint/no-require-imports -- use a shared js file with commonjs export
import environmentUtils = require('@test/shared/environment-utils.cjs');

const onCi = environmentUtils.isRunningOnCi();
Expand Down
6 changes: 5 additions & 1 deletion test/e2e/.eslintrc.cjs
Original file line number Diff line number Diff line change
Expand Up @@ -15,5 +15,9 @@ limitations under the License.
*/

module.exports = {
extends: ['plugin:playwright/jest-playwright'],
extends: ['plugin:playwright/recommended'],
rules: {
/* This rule is for playwright-test and we are using jest-playwright */
'playwright/no-standalone-expect': 'off',
},
};
6 changes: 5 additions & 1 deletion test/performance/.eslintrc.cjs
Original file line number Diff line number Diff line change
Expand Up @@ -15,5 +15,9 @@ limitations under the License.
*/

module.exports = {
extends: ['plugin:playwright/jest-playwright'],
extends: ['plugin:playwright/recommended'],
rules: {
/* This rule is for playwright-test and we are using jest-playwright */
'playwright/no-standalone-expect': 'off',
},
};
3 changes: 2 additions & 1 deletion test/shared/visu/bpmn-page-utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,8 @@ import type { ElementHandle, Page } from 'playwright';
import debugLogger from 'debug';

// eslint-disable-next-line @typescript-eslint/ban-ts-comment
// @ts-ignore js file with commonjs export
// @ts-ignore use a shared js file with commonjs export
// eslint-disable-next-line @typescript-eslint/no-require-imports -- use a shared js file with commonjs export
import environmentUtils = require('../environment-utils.cjs');

import { delay } from './test-utils';
Expand Down