Project og title added in ssr #2181
Conversation
| window.process.env.UPLOAD_LIMIT = ${process.env.UPLOAD_LIMIT ? `${process.env.UPLOAD_LIMIT}` : undefined}; | ||
| window.process.env.MOBILE_ENABLED = ${process.env.MOBILE_ENABLED ? `${process.env.MOBILE_ENABLED}` : undefined}; | ||
| window.process.env.TRANSLATIONS_ENABLED = ${process.env.TRANSLATIONS_ENABLED === 'true' ? true : false}; | ||
| window.process.env.LOGIN_ENABLED = ${ |
There was a problem hiding this comment.
the file was not formatted before for some reason
| `; | ||
| } | ||
|
|
||
| export function renderProjectIndex(projectName, username) { |
There was a problem hiding this comment.
added this function for rendering the user's Project index file
| <meta name="keywords" content="p5.js, p5.js web editor, web editor, processing, code editor" /> | ||
| <meta name="description" content="A web editor for p5.js, a JavaScript library with the goal of making coding accessible to artists, designers, educators, and beginners." /> | ||
| <meta property="og:title" content="${`${projectName} by ${username} -`} p5.js Web Editor" /> | ||
| <title>${`${projectName} by ${username} -`} p5.js Web Editor</title> |
There was a problem hiding this comment.
modified title and also added og:title
|
Thanks for your work on this and sorry for getting to this so late! After looking through it, I think some of the code in the I'm going to close this one for now, but please feel free to revisit this and reopen it or create a new one in the future, thanks again! |
Fixes #2177
Changes:
modified the ssr to show the Open Graph title. please check the file changes for details.
I have verified that this pull request:
npm run lint)npm run test)developbranch.Fixes #123