Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account Settings Page UI for mobile devices #2400

Merged
merged 4 commits into from
Nov 7, 2023
Merged

Account Settings Page UI for mobile devices #2400

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
370c480
account ui update
dewanshDT Sep 9, 2023
5748e5a
fixed width issue
dewanshDT Sep 20, 2023
6e2afdb
Merge branch 'develop' into develop
dewanshDT Oct 28, 2023
27650bb
Merge branch 'develop' into develop
lindapaiste Nov 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions client/styles/components/_account.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,12 @@
background-color: getThemifyVariable('background-color');
}
min-height: 100%;

@media (max-width: 770px) {
.account-settings__header {
display: none;
}
}
}

.account-settings {
Expand All @@ -24,6 +30,16 @@

.account__social-stack {
display: flex;
@media (max-width: 770px) {
flex-direction: column;
align-items: center;
gap: #{15 / $base-font-size}rem;

button, a {
width: 100% !important;
margin-right: 0;
}
}
}

.account__social-stack > * {
Expand Down
5 changes: 5 additions & 0 deletions client/styles/components/_form-container.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@

.form-container__content {
height: 100%;
max-width: 90vw;
display: flex;
flex-direction: column;
justify-content: center;
Expand Down Expand Up @@ -59,6 +60,10 @@

.form-container__divider {
padding: #{20 / $base-font-size}rem 0;

@media (max-width: 770px) {
text-align: center;
}
}

.form-container__logo-button {
Expand Down
9 changes: 7 additions & 2 deletions client/styles/components/_forms.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,14 +56,19 @@
}

.form__input {
max-width: 90vw;
width: #{360 / $base-font-size}rem;
min-width: #{355 / $base-font-size}rem;
width: 100%;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change has unintended consequences as it's used on all form inputs. Check out the login and signup pages on desktop. We might need an override that it specific to the account settings page.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @lindapaiste, sorry for late response, I just fixed the problem, please check it out

height: #{40 / $base-font-size}rem;
font-size: #{16 / $base-font-size}rem;
@include themify() {
color: getThemifyVariable("form-input-text-color");
background-color: getThemifyVariable("input-background-color");
}

@media (max-width: 770px) {
max-width: 100%;
width:100%;
}
}

.form__input-flexible-height {
Expand Down
Loading