Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Moda content overflow and Preferences height #2428

Merged
merged 4 commits into from
Nov 7, 2023
Merged

fix: Moda content overflow and Preferences height #2428

merged 4 commits into from
Nov 7, 2023

Conversation

dewanshDT
Copy link
Collaborator

@dewanshDT dewanshDT commented Sep 12, 2023 •
edited
Loading

Changes:
Fixes the Modal overflow, and preferences height in mobile devices.

this needs to be merged before
#2400 Account UI fix

Before

image

after

image
image

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

@dewanshDT dewanshDT self-assigned this Sep 12, 2023
@dewanshDT dewanshDT changed the title fix: Moda content overflow fix: Moda content overflow and Preferences height Sep 12, 2023
@dewanshDT dewanshDT requested a review from raclim October 28, 2023 11:38
@dewanshDT
Copy link
Collaborator Author

let's merge this guys @lindapaiste @raclim

@lindapaiste lindapaiste merged commit 22ba3de into processing:develop Nov 7, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lindapaiste lindapaiste lindapaiste approved these changes

@raclim raclim Awaiting requested review from raclim

Assignees

@dewanshDT dewanshDT

Labels
Area: Mobile
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dewanshDT @lindapaiste