New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactored Header/MobileNav.jsx with all Todos #3312

Open

Rajnish2105 wants to merge 1 commit into processing:develop from Rajnish2105:refactor-MobileTitle

Rajnish2105 commented Dec 26, 2024

Refactor: Updated "MobileNav.jsx" file with all the todos

Changes:

remove the switch and use a props like mobileTitle
Now component accepts the mobileTitle prop (handled default value and prop type)
An update to PR Refactor MobileNav for handling mobile title more efficiently #3310
use selectRootFile selector
add translations to overlay attributes (title, arialabel)
Add Translations to Settings menuitem in mobilenav

I have verified that this pull request:

has no linting errors (npm run lint)
has no test errors (npm run test)
is from a uniquely-named feature branch and is up to date with the develop branch.
is descriptively named and links to an issue number, i.e. Fixes #123


          Refactored MobileNav with all Todos

62d4f14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet