Fix example category link in the jumpTo on the example detail page. #589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…different from the rules on the parent page. This has been corrected. Before processing#586 was addressed, there was no problem in English. After applying processing#586, the problem was discovered because # and after were created with different rules.
|
Thanks @shibomb! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Relation #585, #586)
Example Category link broken after merge #586.
Details:
Before merge #586, there was no problem in English.
But after merged #586, the problem was discovered because #ID and id attribute were created with different rules.
Category's id attribute in parent page was created with "name.toLowerCase()".
p5.js-website/src/layouts/ExamplesLayout.astro
Line 45 in d24bb80
jumpTo Category's #ID was created with "category".
Changes: