-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
making some links to open in a new tab #439
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! The parts that affect the links look OK to me, but I can't really comment on the contrast issues cause this would need to go through a more extensive review than just adding a couple colors and changing them in a couple places. Also it looks like there's other people working on the second part #441
@fdoflorenzano |
Hi @Dev-Code24, it's great to see you working on this! To keep things organized and manageable, it would be best to limit each Pull Request to addressing one specific issue. This way, we can keep track of progress and make sure each issue is thoroughly addressed. Thanks for your understanding and efforts! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please limit this PR to solving issue #438 and I will merge it. Thank you for your contribution!
Thanks @Dev-Code24 ✨ |
This PR is made because of issue: #438
I have made some changes to all anchor elements where the links should have been opening on a new tab.
The following files have been modified:
BEFORE:
The following links should be opened on a new tab when clicked:
AFTER:
These links now open in a new tab