Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

making some links to open in a new tab #439

Merged
merged 1 commit into from
Feb 13, 2023
Merged

making some links to open in a new tab #439

merged 1 commit into from
Feb 13, 2023

Conversation

Dev-Code24
Copy link
Contributor

@Dev-Code24 Dev-Code24 commented Feb 11, 2023

This PR is made because of issue: #438
I have made some changes to all anchor elements where the links should have been opening on a new tab.
The following files have been modified:
image

BEFORE:
The following links should be opened on a new tab when clicked:
Screenshot 2023-02-11 at 14 07 24
Screenshot 2023-02-11 at 14 06 42

AFTER:
These links now open in a new tab

Copy link
Contributor

@fdoflorenzano fdoflorenzano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! The parts that affect the links look OK to me, but I can't really comment on the contrast issues cause this would need to go through a more extensive review than just adding a couple colors and changing them in a couple places. Also it looks like there's other people working on the second part #441

@Dev-Code24
Copy link
Contributor Author

Dev-Code24 commented Feb 13, 2023

@fdoflorenzano
yeah I also thought that the review would take time, and the part where other people are also working is i guess that person didn't see that i already made a PR and commit regarding the same issue plus tagged the issue too.
So you tell me what should i do next.

@SableRaf
Copy link
Collaborator

Hi @Dev-Code24, it's great to see you working on this! To keep things organized and manageable, it would be best to limit each Pull Request to addressing one specific issue. This way, we can keep track of progress and make sure each issue is thoroughly addressed. Thanks for your understanding and efforts!

Copy link
Collaborator

@SableRaf SableRaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please limit this PR to solving issue #438 and I will merge it. Thank you for your contribution!

@Dev-Code24
Copy link
Contributor Author

Dev-Code24 commented Feb 13, 2023

ok @SableRaf i'll limit this PR to the issue #438. Let me just reset the head

@SableRaf SableRaf merged commit 5d052d6 into processing:main Feb 13, 2023
@SableRaf
Copy link
Collaborator

Thanks @Dev-Code24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants