Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolved Issue with Image Overlapping on Processing.org Examples Page #514 #538

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Lavanyaa09
Copy link

I have observed an issue in example page of processing website where i resolved the issue by using 4 columns instead of 5 at the largest width on the examples page, leaving space on the right.
processingwebsitechanges.pdf

Copy link

netlify bot commented Jul 18, 2024

Deploy Preview for java-processing-faf822 ready!

Name Link
🔨 Latest commit 35506e4
🔍 Latest deploy log https://app.netlify.com/sites/java-processing-faf822/deploys/6698ea89be44b900089ad62b
😎 Deploy Preview https://deploy-preview-538--java-processing-faf822.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@SableRaf SableRaf requested review from Stefterv and SableRaf July 18, 2024 10:30
@SableRaf
Copy link
Collaborator

Thanks for your contribution @Lavanyaa09 ✨ Appreciate you taking the time.

I'm noticing that the changes (right side) are applied globally across breakpoint sizes.

It may actually work a the medium size but it breaks on mobile. See the screenshots below:

image image

@Lavanyaa09
Copy link
Author

Hello @SableRaf,

I am pleased to inform you that the updates are now successfully functioning on the web interface globally. I will proceed to work on optimizing the mobile view and will merge the changes accordingly.

Thank you for your guidance and support.

Copy link
Contributor

@Stefterv Stefterv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes work so they could be merged, but I think there might be an opportunity to fix the issue with more sustainable approaches

@@ -1,7 +1,7 @@
.root {
position: fixed;
top: 130px;
right: var(--margin);
right: calc(var(--margin) - 1cm);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

centimeters have not been used yet in the codebase, please use some of the constants in the variables.css

@@ -42,7 +42,8 @@
}

.item {
flex-basis: calc(100% / 5);
flex: 0 0 calc(25% - 2 * var(--gutter));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix works, could you research if you could scale the container element instead?

@SableRaf
Copy link
Collaborator

@Lavanyaa09 If you're still interested in this PR, could you take a look at the comments above? Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants