Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes Facebook link in footer #594

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fixes Facebook link in footer #594

wants to merge 2 commits into from

Conversation

twisst
Copy link
Contributor

@twisst twisst commented Dec 22, 2024

No description provided.

Copy link

netlify bot commented Dec 22, 2024

Deploy Preview for java-processing-faf822 ready!

Name Link
🔨 Latest commit b08fa3d
🔍 Latest deploy log https://app.netlify.com/sites/java-processing-faf822/deploys/676ad5e316c1550008d37d1a
😎 Deploy Preview https://deploy-preview-594--java-processing-faf822.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@SableRaf SableRaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link was incorrect but we have a new dedicated Facebook page for Processing:
https://www.facebook.com/people/Processing-Core/

@twisst
Copy link
Contributor Author

twisst commented Dec 22, 2024

https://www.facebook.com/people/Processing-Core/

Could be me but that link leads to a 'not available' page. Maybe it is set to private?

@SableRaf
Copy link
Collaborator

Hmm, it is visible to some people at least—posts are getting reactions—but it is possible you need to be logged in to see it according to this help article.

If your Page has age or country restrictions, you won't be able to see it when you're logged out of Facebook.

To see your Page when you're logged out, you'll need to remove all age and country restrictions:

I'll investigate these settings.

@SableRaf
Copy link
Collaborator

Everything is set to public and there are no age nor country restrictions.

Looks like I just got the wrong link. Could you try this one?

https://www.facebook.com/people/Processing-Core/61567491443061/

@twisst
Copy link
Contributor Author

twisst commented Dec 22, 2024

https://www.facebook.com/people/Processing-Core/61567491443061/

That page does open! When I open the main link, I just see this:
afbeelding

And that's also what I see when I try to open it from a private browsing window and whether I am logged in or not. When not logged in I do see the page of the link above behind the log-in window, but not so with the main page. So strange.

@SableRaf
Copy link
Collaborator

Strange! For me that link works even in an incognito window

image

Copy link
Collaborator

@SableRaf SableRaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @twisst I think you might have included these changes in the "fixes Facebook link in footer" PR by mistake.

In fact, most of these changes can't be made directly in the website repository anyway. For example, the contributions, reference, and examples are all generated from other sources. See: the Page content section of the README.

This whole system is a bit convoluted, so it's completely understandable. If you have any questions or need assistance, feel free to reach out :)

Thanks so much for your effort and contributions!

@twisst
Copy link
Contributor Author

twisst commented Dec 24, 2024

Hey @twisst I think you might have included these changes in the "fixes Facebook link in footer" PR by mistake.

Hi @SableRaf, yeah I noticed. I was already looking at the scary Github magic required. I'll give it a try.

In fact, most of these changes can't be made directly in the website repository anyway.

Ouch. Oh well, I'll just consider it good practice :-)

Thanks so much for your effort and contributions!

Glad to help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants