Skip to content

Commit

Permalink
Merge pull request #3313 from projectblacklight/backport-redundent-ro…
Browse files Browse the repository at this point in the history
…les-to-release-4x

Backport remove redundent aria roles from semantic elements to release 4.x
  • Loading branch information
jcoyne authored Dec 4, 2024
2 parents 5843d5e + 8af8973 commit 7ef5b6d
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion app/views/layouts/spotlight/base.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
<%= render partial: 'shared/masthead' %>
<%= content_for?(:header_content) ? yield(:header_content) : "" %>

<main id="main-container" class="<%= container_classes %>" role="main" aria-label="<%= t('blacklight.main.aria.main_container') %>">
<main id="main-container" class="<%= container_classes %>" aria-label="<%= t('blacklight.main.aria.main_container') %>">
<%= content_for(:container_header) %>

<%= render partial: 'shared/flash_msg', layout: 'shared/flash_messages' %>
Expand Down
2 changes: 1 addition & 1 deletion app/views/shared/_masthead.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
<% end %>
<% end %>

<header class="masthead <%= 'image-masthead' if current_masthead %> <%= 'resource-masthead' if resource_masthead? %>" role="banner">
<header class="masthead <%= 'image-masthead' if current_masthead %> <%= 'resource-masthead' if resource_masthead? %>">
<% if current_masthead %>
<span class='background-container' style="background-image: url('<%= current_masthead.iiif_url %>')"></span>
<span class='background-container-gradient'></span>
Expand Down

0 comments on commit 7ef5b6d

Please sign in to comment.