Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable selection of image area for non-embed item widgets (other than uploaded item) #3350

Merged
merged 25 commits into from
Dec 20, 2024
Merged

Enable selection of image area for non-embed item widgets (other than uploaded item) #3350

Show file tree
Hide file tree
Changes from 20 commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
7d3a67a
first pass
hudajkhan Dec 6, 2024
e5e7b6d
changing approach for attaching event handler for modal
hudajkhan Dec 10, 2024
b92faff
remove unused function
hudajkhan Dec 10, 2024
beb2622
save and display thumbnail url for cropped item
hudajkhan Dec 10, 2024
efcd739
some refactoring and styling changes
hudajkhan Dec 12, 2024
80d1b9c
fixing rubocop/debugging
hudajkhan Dec 12, 2024
0e60f79
normalized
hudajkhan Dec 12, 2024
ec72131
handling block level uniqueness, adding beginning for upload support,…
hudajkhan Dec 13, 2024
84f7730
rubocop
hudajkhan Dec 13, 2024
c74a6e7
allowing aspect ratio not to be preserved
hudajkhan Dec 13, 2024
2470d80
removing upload item portion
hudajkhan Dec 13, 2024
a4b18f8
added tests and more cleanup
hudajkhan Dec 14, 2024
5ed389f
removing unnecessary imports
hudajkhan Dec 14, 2024
b4aa23f
post run prepare
hudajkhan Dec 14, 2024
7da42df
updating crop construtor and module to work with same initialization …
hudajkhan Dec 18, 2024
e65a8d5
merging in from main
hudajkhan Dec 18, 2024
7c16423
fixing test
hudajkhan Dec 18, 2024
c0aa0c6
removing form-prefix where not needed
hudajkhan Dec 18, 2024
af5ccfb
cleanup debugging
hudajkhan Dec 18, 2024
4fd21c0
removing extra space
hudajkhan Dec 18, 2024
91f62f4
removing comments
hudajkhan Dec 19, 2024
621a6ea
handling absence of linked autocomplete for widget editing
hudajkhan Dec 19, 2024
eade3eb
remove unnecessary code, update comment
hudajkhan Dec 19, 2024
7606385
Merge branch 'main' into selectimage
hudajkhan Dec 20, 2024
9f5ad51
merging in main
hudajkhan Dec 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
214 changes: 185 additions & 29 deletions app/assets/javascripts/spotlight/spotlight.esm.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion app/assets/javascripts/spotlight/spotlight.esm.js.map
View file
Open in desktop

Large diffs are not rendered by default.

Loading
Loading