Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 'yarn link' in the test app #3381

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Use 'yarn link' in the test app #3381

merged 1 commit into from
Dec 20, 2024

Conversation

taylor-steve
Copy link
Contributor

@taylor-steve taylor-steve commented Dec 19, 2024

Now that app.config.assets.paths << Rails.root.join('node_modules') has been removed via #3378 we can go back to using yarn link for the test app. It seems like that fixes our previous infinite propshaft issue.

This fixes the test app build, which is currently broken:

07:58:13 css.1  | Error: Can't find stylesheet to import.
07:58:13 css.1  |   ╷
07:58:13 css.1  | 5 │ @import "spotlight-frontend/vendor/assets/stylesheets/bootstrap-tagsinput";
07:58:13 css.1  |   │         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
07:58:13 css.1  |   ╵
07:58:13 css.1  |   app/assets/stylesheets/spotlight.scss 5:9              @import
07:58:13 css.1  |   app/assets/stylesheets/application.bootstrap.scss 4:9  root stylesheet
07:58:13 css.1  | error Command failed with exit code 65.
07:58:13 css.1  | info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
07:58:13 css.1  | error Command failed with exit code 65.
07:58:13 css.1  | info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
07:58:13 css.1  | [nodemon] app crashed - waiting for file changes before starting...

@taylor-steve taylor-steve marked this pull request as ready for review December 20, 2024 16:09
@jcoyne jcoyne merged commit e34edf5 into main Dec 20, 2024
5 checks passed
@jcoyne jcoyne deleted the use-yarn-link branch December 20, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants