Keep track of metric names on the metric statsd_exporter_events_confl…

…ict_total Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com>
prometheus · Dec 23, 2024 · d45b0e3 · d45b0e3
1 parent 32fee3f
commit d45b0e3
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/main.go b/main.go
@@ -148,7 +148,7 @@ var (
 			Name: "statsd_exporter_events_conflict_total",
 			Help: "The total number of StatsD events with conflicting names.",
 		},
-		[]string{"type"},
+		[]string{"type", "metric_name"},
 	)
 	errorEventStats = promauto.NewCounterVec(
 		prometheus.CounterOpts{

diff --git a/pkg/exporter/exporter.go b/pkg/exporter/exporter.go
@@ -137,7 +137,7 @@ func (b *Exporter) handleEvent(thisEvent event.Event) {
 			b.EventStats.WithLabelValues("counter").Inc()
 		} else {
 			b.Logger.Debug(regErrF, "metric", metricName, "error", err)
-			b.ConflictingEventStats.WithLabelValues("counter").Inc()
+			b.ConflictingEventStats.WithLabelValues("counter", metricName).Inc()
 		}
 
 	case *event.GaugeEvent:
@@ -152,7 +152,7 @@ func (b *Exporter) handleEvent(thisEvent event.Event) {
 			b.EventStats.WithLabelValues("gauge").Inc()
 		} else {
 			b.Logger.Debug(regErrF, "metric", metricName, "error", err)
-			b.ConflictingEventStats.WithLabelValues("gauge").Inc()
+			b.ConflictingEventStats.WithLabelValues("gauge", metricName).Inc()
 		}
 
 	case *event.ObserverEvent:
@@ -172,7 +172,7 @@ func (b *Exporter) handleEvent(thisEvent event.Event) {
 				b.EventStats.WithLabelValues("observer").Inc()
 			} else {
 				b.Logger.Debug(regErrF, "metric", metricName, "error", err)
-				b.ConflictingEventStats.WithLabelValues("observer").Inc()
+				b.ConflictingEventStats.WithLabelValues("observer", metricName).Inc()
 			}
 
 		case mapper.ObserverTypeDefault, mapper.ObserverTypeSummary:
@@ -182,7 +182,7 @@ func (b *Exporter) handleEvent(thisEvent event.Event) {
 				b.EventStats.WithLabelValues("observer").Inc()
 			} else {
 				b.Logger.Debug(regErrF, "metric", metricName, "error", err)
-				b.ConflictingEventStats.WithLabelValues("observer").Inc()
+				b.ConflictingEventStats.WithLabelValues("observer", metricName).Inc()
 			}
 
 		default:

diff --git a/pkg/exporter/exporter_test.go b/pkg/exporter/exporter_test.go
@@ -117,7 +117,7 @@ var (
 			Name: "statsd_exporter_events_conflict_total",
 			Help: "The total number of StatsD events with conflicting names.",
 		},
-		[]string{"type"},
+		[]string{"type", "metric_name"},
 	)
 	errorEventStats = prometheus.NewCounterVec(
 		prometheus.CounterOpts{