Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add instructions for updating wasmtime #322

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

phlax
Copy link
Contributor

@phlax phlax commented Nov 21, 2022

Signed-off-by: Ryan Northey ryan@synca.io

Signed-off-by: Ryan Northey <ryan@synca.io>
@phlax
Copy link
Contributor Author

phlax commented Nov 21, 2022

cc @kfaseela @RiverPhillips

@RiverPhillips
Copy link
Contributor

RiverPhillips commented Nov 21, 2022

Would be helpful to document the manual changes required as a result of this bug. google/cargo-raze#451

It caused me a lot of pain

@phlax
Copy link
Contributor Author

phlax commented Nov 21, 2022

yep just hitting that now 8(

(#319 )

any ideas on how to fix ?

@PiotrSikora
Copy link
Member

@phlax Is this finished? I thought there were a few more things that you wanted to add here, but I don't recall details.

@phlax
Copy link
Contributor Author

phlax commented Dec 16, 2022

I thought there were a few more things that you wanted to add here, but I don't recall details.

i can have a go - its the issue of resolving duplicates - not sure exactly what to say - iirc the easiest is to diff the changed files but dont rem exactly what/where

Signed-off-by: Ryan Northey <ryan@synca.io>

Resolving this issue can be tricky as updates can generate a lot of change, but essentially
you will need to check the overall diff for any problematic files and check to see where new
dependencies have been added.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PiotrSikora this feels pretty unsatisfactory but looking over the actual diffs (and checking through my/others attempts to resolve) im not clear what the process here should be

when we recently updated this - i seem to rem right at the end a penny dropping and thinking "ok, got it" but im not sure what that was now or how to describe in a way that will work given the different possibilities regenerating the file has.

is there any way we could resolve the upstream raze issue ?

## Install `cargo-raze`

```console
$ cargo install cargo-raze --version 0.14.1.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
$ cargo install cargo-raze --version 0.14.1.
$ cargo install cargo-raze --version 0.14.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants