compdb add the compdb support to the proxy_wasm_cpp_host #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: wangbaiping <wbphub@gmail.com>
wbpcode
requested review from
PiotrSikora,
martijneken and
mpwarres
as code owners
Signed-off-by: wangbaiping <wbphub@gmail.com>
|
cc @mpwarres (PS: we cannot assign the PR, is there a team like assignable?) |
I believe that only maintainers can assign the PR to someone from an assignable team (there is @proxy-wasm/committers-c), but all codeowners are automatically added as reviewers and notified about the PR. |
PiotrSikora
reviewed
Sep 26, 2024
Signed-off-by: wangbaiping <wbphub@gmail.com>
mpwarres
reviewed
Sep 26, 2024
Signed-off-by: wangbaiping <wbphub@gmail.com>
|
@PiotrSikora LMK if you have further comments, otherwise I'll go ahead and merge this. Thanks! |
PiotrSikora
reviewed
Sep 27, 2024
Signed-off-by: wangbaiping <wbphub@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the compdb support to the repo. This could be used to simplify the development process.
Note the
grailbio/bazel-compilation-databaseis archived. But it is still be used by envoyproxy/envoy and works pretty well.So, if it is good enough for envoyproxy/envoy, then it should be good enough for proxy_wasm_cpp_host.
And I also investigate other choices like hedronvision/bazel-compile-commands-extractor, but now it could works for our repo.