-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix references to prefix_wasm_api #420
Conversation
Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>
@keithmattix The change looks fine, but could you please confirm that it fixes the build and tests with |
@PiotrSikora I at least got past the error @wbpcode reported in #418, but am now dealing with wasmedge failures. I haven't been able to get past them yet, but will keep trying. If @wbpcode has a working setup, they may be able to confirm before I can. I think the wasmedge compilation step is considering all of my warnings as errors and I'm trying to find where I can disable that |
@PiotrSikora FWIW, I faced the same problem as in #418 and arrived to the same fix as @keithmattix did. I checked that it addresses the problem for me and the command from #418 works for me now:
Would it count as verification enough to merge this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
@mpwarres @martijneken could you guys review and merge it? Thanks! |
Ping? |
@martijneken @mpwarres ping? |
Sorry for the delay and thanks for the nudge, this fell through the cracks. Thanks for the fix! |
References to
include/wasm.h
changed tocrates/c-api/include/wasm.h
, so the prefixed api output needs to change as well. Fixes #418