Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back delivery fields #21

Closed
wants to merge 22 commits into from
Closed

Conversation

stoe
Copy link
Contributor

@stoe stoe commented Sep 19, 2023

Via git cherry-pick c9bdd93 ce14abf

  • Declare offering delivery method and unit. c9bdd93
  • Fix phrasing ce14abf

@stoe stoe requested a review from ppremk as a code owner September 19, 2023 09:06
@stoe stoe self-assigned this Sep 19, 2023
@stoe stoe requested a review from igwejk September 19, 2023 09:06
igwejk and others added 4 commits September 19, 2023 11:29
This change should facilitate implementation of automations that consumes the offering feed e.g. scoping enhancement github/services#19929
Co-authored-by: Stefan Stölzle <stoe@github.com>
Delivery entry in post item should be an object.
@igwejk igwejk force-pushed the stoe/add-delivery-object-back branch from d415d99 to e75310f Compare September 19, 2023 09:30
@stoe stoe marked this pull request as draft September 19, 2023 10:10
@stoe stoe force-pushed the stoe/add-delivery-object-back branch from ec347bb to 7e9a6ad Compare September 19, 2023 10:17
.github/workflows/ci.yml Outdated Show resolved Hide resolved
Rakefile Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
Gemfile Outdated Show resolved Hide resolved
Rakefile Outdated Show resolved Hide resolved
Rakefile Outdated Show resolved Hide resolved
stoe and others added 2 commits September 19, 2023 16:15
Co-authored-by: Igwe Kalu <igwejk@users.noreply.github.com>
@ppremk
Copy link
Collaborator

ppremk commented Sep 20, 2023

@stoe @igwejk when ready please block time with me to go over the changes and how this impacts the scoping automation you are working on. It will help for me to get an overall idea on how this changes impacts your needs and why we are making changes in these feeds. This will help me bring the right messaging to the team which will be maintaining this site in the future when we need/plan to make changes.

@stoe
Copy link
Contributor Author

stoe commented Sep 20, 2023

@stoe @igwejk when ready please block time with me to go over the changes and how this impacts the scoping automation you are working on. It will help for me to get an overall idea on how this changes impacts your needs and why we are making changes in these feeds. This will help me bring the right messaging to the team which will be maintaining this site in the future when we need/plan to make changes.

🐙🐱💖
I'll let @igwejk drive, and support where needed.

@igwejk, can you find a 📆 calendar slot that works (at least for you and @ppremk) for a quick sync, as I think this work is ready now.

@igwejk igwejk closed this Sep 27, 2023
@igwejk igwejk deleted the stoe/add-delivery-object-back branch September 27, 2023 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants