Merge branch 'develop' into 4191-fix-cells-clickable-v2

public-ui · Jan 24, 2024 · 0aaf631 · 0aaf631
2 parents 34173e2 + 9ff83f9
commit 0aaf631
Show file tree

Hide file tree

Showing 6 changed files with 6 additions and 7 deletions.
diff --git a/packages/components/src/components/button/test/html.mock.ts b/packages/components/src/components/button/test/html.mock.ts
@@ -21,6 +21,7 @@ export const getButtonWcHtml = (
 		{
 			_icons: {},
 			_label: '', // ⚠ required
+			_on: {},
 			_type: 'button',
 			_variant: 'normal',
 		},

diff --git a/packages/components/src/components/details/component.tsx b/packages/components/src/components/details/component.tsx
@@ -67,7 +67,7 @@ export class KolDetails implements DetailsAPI {
 	@Prop({ mutable: true, reflect: true }) public _open?: boolean = false;
 
 	@State() public state: DetailsStates = {
-		_label: '…', // '⚠'
+		_label: '', // ⚠ required
 		_on: {},
 	};
 

diff --git a/packages/components/src/components/details/test/html.mock.ts b/packages/components/src/components/details/test/html.mock.ts
@@ -13,7 +13,7 @@ export const getDetailsHtml = (
 ): string => {
 	props = mixMembers(
 		{
-			_label: '…',
+			_label: '', // ⚠ required
 		},
 		props
 	);

diff --git a/packages/components/src/components/link/test/html.mock.ts b/packages/components/src/components/link/test/html.mock.ts
@@ -10,11 +10,9 @@ import type { LinkProps, LinkStates } from '@public-ui/schema';
 export const getLinkHtml = (props: LinkProps, innerHTML = ''): string => {
 	const state = mixMembers<LinkProps, LinkStates>(
 		{
+			_ariaCurrentValue: 'page',
 			_href: '', // ⚠ required
-			_hideLabel: false,
 			_icons: {},
-			_tooltipAlign: 'right',
-			_ariaCurrentValue: 'page',
 		},
 		props
 	);

diff --git a/packages/components/src/components/table/component.tsx b/packages/components/src/components/table/component.tsx
@@ -106,13 +106,13 @@ export class KolTable implements TableAPI {
 
 	@State() public state: TableStates = {
 		_allowMultiSort: false,
-		_label: '', // ⚠ required
 		_data: [],
 		_dataFoot: [],
 		_headers: {
 			horizontal: [],
 			vertical: [],
 		},
+		_label: '', // ⚠ required
 		_pagination: {
 			_page: 1,
 			_pageSize: 10,

diff --git a/packages/samples/react/package.json b/packages/samples/react/package.json
@@ -10,7 +10,7 @@
 		"format": "prettier --check src",
 		"lint": "eslint \"{src,tests}/**/*.{html,js,json,jsx,ts,tsx,gql,graphql}\"",
 		"serve": "cross-env NODE_ENV=development webpack serve --devtool=source-map",
-		"start": "npm run serve",
+		"start": "npm run serve -- --open",
 		"unused": "ts-prune -e src",
 		"postinstall": "npm-run-all postinstall:*",
 		"postinstall:components-assets": "cpy \"node_modules/@public-ui/components/assets/**/*\" public/assets --dot",