Skip to content

Commit

Permalink
Remove deprecated property alert from combobox
Browse files Browse the repository at this point in the history
Refs: #7015
  • Loading branch information
sdvg committed Dec 17, 2024
1 parent fd4be81 commit 5c1515f
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 16 deletions.
16 changes: 1 addition & 15 deletions packages/components/src/components/combobox/shadow.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -376,12 +376,6 @@ export class KolCombobox implements ComboboxAPI {
*/
@Prop() public _placeholder?: string;

/**
* Defines whether the screen-readers should read out the notification.
* @deprecated Will be removed in v3. Use automatic behaviour instead.
*/
@Prop({ mutable: true, reflect: true }) public _alert?: boolean;

/**
* Makes the element not focusable and ignore all events.
*/
Expand Down Expand Up @@ -495,10 +489,7 @@ export class KolCombobox implements ComboboxAPI {
}

private showAsAlert(): boolean {
if (this.state._alert === undefined) {
return Boolean(this.state._touched) && !this.inputHasFocus;
}
return this.state._alert;
return Boolean(this.state._touched) && !this.inputHasFocus;
}

@Watch('_placeholder')
Expand All @@ -511,11 +502,6 @@ export class KolCombobox implements ComboboxAPI {
this.controller.validateAccessKey(value);
}

@Watch('_alert')
public validateAlert(value?: boolean): void {
this.controller.validateAlert(value);
}

@Watch('_disabled')
public validateDisabled(value?: boolean): void {
this.controller.validateDisabled(value);
Expand Down
1 change: 0 additions & 1 deletion packages/components/src/schema/components/combobox.ts
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@ type RequiredStates = {
PropHideError &
PropLabelWithExpertSlot;
type OptionalStates = {
alert: boolean;
hint: string;
icons: KoliBriHorizontalIcons;
on: InputTypeOnDefault;
Expand Down

0 comments on commit 5c1515f

Please sign in to comment.