Remove accessKey from initial states and make sure they're not required

public-ui · Oct 27, 2023 · 6037f6e · 6037f6e
1 parent 52af81a
commit 6037f6e
Show file tree

Hide file tree

Showing 5 changed files with 1 addition and 5 deletions.
diff --git a/packages/components/src/components/button/component.tsx b/packages/components/src/components/button/component.tsx
@@ -229,7 +229,6 @@ export class KolButtonWc implements API {
 		_on: {},
 		_type: 'button', // ⚠ required
 		_variant: 'normal', // ⚠ required
-		_accessKey: '',
 	};
 
 	public constructor() {

diff --git a/packages/components/src/components/span/component.tsx b/packages/components/src/components/span/component.tsx
@@ -93,7 +93,6 @@ export class KolSpanWc implements API {
 		_hideLabel: false,
 		_icons: {},
 		_label: '', // ⚠ required
-		_accessKey: '',
 	};
 
 	@Watch('_accessKey')

diff --git a/packages/components/src/components/tooltip/component.tsx b/packages/components/src/components/tooltip/component.tsx
@@ -169,7 +169,6 @@ export class KolTooltip implements API {
 	@Prop() public _label!: LabelPropType;
 
 	@State() public state: States = {
-		_accessKey: '',
 		_align: 'top',
 		_id: nonce(),
 		_label: '…', // ⚠ required

diff --git a/packages/components/src/components/tooltip/test/html.mock.ts b/packages/components/src/components/tooltip/test/html.mock.ts
@@ -7,7 +7,6 @@ import { Props, States } from '../types';
 export const getTooltipHtml = (props: Props, additionalAttrs = ''): string => {
 	const state: States = mixMembers<Props, States>(
 		{
-			_accessKey: '',
 			_align: 'top',
 			_id: nonce(),
 			_label: '…', // ⚠ required

diff --git a/packages/components/src/components/tooltip/types.ts b/packages/components/src/components/tooltip/types.ts
@@ -9,7 +9,7 @@ type RequiredProps = PropLabel;
 type OptionalProps = PropAlign & PropId & PropAccessKey;
 export type Props = Generic.Element.Members<RequiredProps, OptionalProps>;
 
-type RequiredStates = RequiredProps & OptionalProps;
+type RequiredStates = RequiredProps & PropAlign & PropId;
 type OptionalStates = NonNullable<unknown>;
 
 export type States = Generic.Element.Members<RequiredStates, OptionalStates>;