Skip to content

Commit

Permalink
Remove deprecated components and focus methods (#7205)
Browse files Browse the repository at this point in the history
  • Loading branch information
laske185 authored Dec 19, 2024
2 parents e209dcf + d40c719 commit 901a6e2
Show file tree
Hide file tree
Showing 108 changed files with 89 additions and 2,081 deletions.
5 changes: 1 addition & 4 deletions .github/ISSUE_TEMPLATE/1.bug_report.yml
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,6 @@ body:
- 'Avatar'
- 'Badge'
- 'Breadcrumb'
- 'Button-Group'
- 'Button-Link'
- 'Button'
- 'Card'
Expand All @@ -89,7 +88,6 @@ body:
- 'Heading'
- 'Icon'
- 'Image'
- 'Indented-Text'
- 'Input-Checkbox'
- 'Input-Color'
- 'Input-Date'
Expand All @@ -101,7 +99,6 @@ body:
- 'Input-Range'
- 'Input-Text'
- 'Link-Button'
- 'Link-Group'
- 'Link'
- 'Modal'
- 'Nav'
Expand Down Expand Up @@ -171,4 +168,4 @@ body:
}
}
validations:
required: true
required: true
16 changes: 15 additions & 1 deletion docs/BREAKING_CHANGES.v3.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,27 @@ New major versions of KoliBri are developed with the goal of simplifying mainten

For more information, see the [KoliBri Maintenance and Support Strategy](https://github.com/public-ui/kolibri/blob/develop/MIGRATION.md).

## Components
## Removed Components

The following components have been removed:

- kol-button-group
- kol-indented-text
- kol-link-group
- kol-logo
- kol-table

## Changed Components

### kol-abbr

- Visually, the tooltip has been replaced by a simple label shown in parentheses after the abbreviation.
- The property `_tooltipAlign` has been removed.

## `focus`-methods

The public `focus`-methods have been removed from all components. Use `kolFocus` instead.

## All Input Components

- The property `_alert` has been removed. It's now being handled automatically based on `_msg` and the touched state. See #6138.
Expand Down
3 changes: 2 additions & 1 deletion packages/components/.eslintignore
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
**/assets/**
src/**/*.js
src/**/*.html
src/**/*.html
scripts/vaadin.js
3 changes: 0 additions & 3 deletions packages/components/scripts/vaadin.js
Original file line number Diff line number Diff line change
Expand Up @@ -54,16 +54,13 @@ const javaType = (type, required) => {
const BLACKLIST = [
'kol-alert-wc',
'kol-avatar-wc',
'kol-button-group',
'kol-button-group-wc',
'kol-color',
'kol-counter',
'kol-heading-wc',
'kol-icon-font-awesome',
'kol-icon-icofont',
'kol-input-adapter-leanup',
'kol-input-radio-group',
'kol-link-group',
'kol-span',
'kol-span-wc',
];
Expand Down
7 changes: 0 additions & 7 deletions packages/components/src/components/@else/all/component.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@ import type { Generic } from 'adopted-style-sheets';
import type { JSX } from '@stencil/core';
import { h, Host, State } from '@stencil/core';

import { Bundesministerium } from '../../../enums/bund';

type RequiredProps = NonNullable<unknown>;
type OptionalProps = NonNullable<unknown>;
// type Props = Generic.Element.Members<RequiredProps, OptionalProps>;
Expand All @@ -28,15 +26,13 @@ export class KolAll implements Generic.Element.ComponentApi<RequiredProps, Optio
<kol-badge _label="Label"></kol-badge>
<kol-breadcrumb _label="" _links={[]}></kol-breadcrumb>
<kol-button _label="Label" _on={{}}></kol-button>
<kol-button-group></kol-button-group>
<kol-card _label=""></kol-card>
<kol-details _label=""></kol-details>
<kol-form _on={{}}></kol-form>
<kol-heading _label=""></kol-heading>
<kol-icon _label="" _icons="codicon codicon-home"></kol-icon>
<kol-icon-font-awesome _ariaLabel="" _icon="500px" _prefix="fab"></kol-icon-font-awesome>
<kol-icon-icofont _ariaLabel="" _icon="home"></kol-icon-icofont>
<kol-indented-text></kol-indented-text>
<kol-input-checkbox _label="" _value="test"></kol-input-checkbox>
<kol-input-color _label=""></kol-input-color>
<kol-input-email _label=""></kol-input-email>
Expand All @@ -47,16 +43,13 @@ export class KolAll implements Generic.Element.ComponentApi<RequiredProps, Optio
<kol-input-range _label=""></kol-input-range>
<kol-input-text _label=""></kol-input-text>
<kol-link _href="" _label="Label"></kol-link>
<kol-link-group _label="" _links={[]}></kol-link-group>
<kol-logo _org={Bundesministerium['Auswärtiges Amt']}></kol-logo>
<kol-modal _label=""></kol-modal>
<kol-nav _label="" _links={[]}></kol-nav>
<kol-pagination _on={{}} _page={1} _max={11}></kol-pagination>
<kol-progress _max={10} _value={5}></kol-progress>
<kol-select _label="" _options={[]}></kol-select>
<kol-skip-nav _label="" _links={[]}></kol-skip-nav>
<kol-spin></kol-spin>
<kol-table _label="" _data={[]} _headers={{}}></kol-table>
<kol-tabs _label="" _tabs={[]}></kol-tabs>
<kol-textarea _label=""></kol-textarea>
<kol-tooltip-wc _label="Label"></kol-tooltip-wc>
Expand Down
18 changes: 0 additions & 18 deletions packages/components/src/components/@else/all/readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,15 +12,13 @@
- [kol-badge](../badge)
- [kol-breadcrumb](../breadcrumb)
- [kol-button](../button)
- [kol-button-group](../button-group)
- [kol-card](../card)
- [kol-details](../details)
- [kol-form](../form)
- [kol-heading](../heading)
- [kol-icon](../icon)
- [kol-icon-font-awesome](../icon-font-awesome)
- [kol-icon-icofont](../icon-icofont)
- [kol-indented-text](../indented-text)
- [kol-input-checkbox](../input-checkbox)
- [kol-input-color](../input-color)
- [kol-input-email](../input-email)
Expand All @@ -31,16 +29,13 @@
- [kol-input-range](../input-range)
- [kol-input-text](../input-text)
- [kol-link](../link)
- [kol-link-group](../link-group)
- [kol-logo](../logo)
- [kol-modal](../modal)
- [kol-nav](../nav)
- [kol-pagination](../pagination)
- [kol-progress](../progress)
- [kol-select](../select)
- [kol-skip-nav](../skip-nav)
- [kol-spin](../spin)
- [kol-table](../table)
- [kol-tabs](../tabs)
- [kol-textarea](../textarea)
- [kol-tooltip](../tooltip)
Expand All @@ -56,15 +51,13 @@ graph TD;
kol-all --> kol-badge
kol-all --> kol-breadcrumb
kol-all --> kol-button
kol-all --> kol-button-group
kol-all --> kol-card
kol-all --> kol-details
kol-all --> kol-form
kol-all --> kol-heading
kol-all --> kol-icon
kol-all --> kol-icon-font-awesome
kol-all --> kol-icon-icofont
kol-all --> kol-indented-text
kol-all --> kol-input-checkbox
kol-all --> kol-input-color
kol-all --> kol-input-email
Expand All @@ -75,16 +68,13 @@ graph TD;
kol-all --> kol-input-range
kol-all --> kol-input-text
kol-all --> kol-link
kol-all --> kol-link-group
kol-all --> kol-logo
kol-all --> kol-modal
kol-all --> kol-nav
kol-all --> kol-pagination
kol-all --> kol-progress
kol-all --> kol-select
kol-all --> kol-skip-nav
kol-all --> kol-spin
kol-all --> kol-table
kol-all --> kol-tabs
kol-all --> kol-textarea
kol-all --> kol-tooltip
Expand All @@ -105,8 +95,6 @@ graph TD;
kol-button --> kol-tooltip
kol-card --> kol-heading
kol-details --> kol-icon-icofont
kol-details --> kol-indented-text
kol-form --> kol-indented-text
kol-icon-font-awesome --> kol-icon
kol-input-checkbox --> kol-alert
kol-input-color --> kol-alert
Expand All @@ -117,17 +105,11 @@ graph TD;
kol-input-radio --> kol-alert
kol-input-range --> kol-alert
kol-input-text --> kol-alert
kol-link-group --> kol-heading
kol-link-group --> kol-link
kol-nav --> kol-link
kol-nav --> kol-button
kol-pagination --> kol-button
kol-select --> kol-alert
kol-skip-nav --> kol-link
kol-table --> kol-button
kol-table --> kol-button-group
kol-table --> kol-select
kol-tabs --> kol-button-group
kol-tabs --> kol-icon-icofont
kol-textarea --> kol-alert
kol-version --> kol-badge
Expand Down
8 changes: 0 additions & 8 deletions packages/components/src/components/accordion/shadow.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -42,14 +42,6 @@ export class KolAccordion implements AccordionAPI, FocusableElement {
this.buttonWcRef = ref;
};

/**
* @deprecated Use kolFocus instead.
*/
@Method()
public async focus() {
await this.kolFocus();
}

@Method()
public async kolFocus() {
await this.buttonWcRef?.kolFocus();
Expand Down
23 changes: 0 additions & 23 deletions packages/components/src/components/button-group/component.tsx

This file was deleted.

23 changes: 0 additions & 23 deletions packages/components/src/components/button-group/shadow.tsx

This file was deleted.

13 changes: 0 additions & 13 deletions packages/components/src/components/button-group/style.scss

This file was deleted.

This file was deleted.

This file was deleted.

8 changes: 0 additions & 8 deletions packages/components/src/components/button-link/shadow.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -42,14 +42,6 @@ export class KolButtonLink implements ButtonLinkProps, FocusableElement {
return this._value;
}

/**
* @deprecated Use kolFocus instead.
*/
@Method()
public async focus() {
await this.kolFocus();
}

@Method()
public async kolFocus() {
await this.buttonWcRef?.kolFocus();
Expand Down
8 changes: 0 additions & 8 deletions packages/components/src/components/button/shadow.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -42,14 +42,6 @@ export class KolButton implements ButtonProps, FocusableElement {
return this._value;
}

/**
* @deprecated Use kolFocus instead.
*/
@Method()
public async focus() {
await this.kolFocus();
}

@Method()
public async kolFocus() {
await this.buttonWcRef?.kolFocus();
Expand Down
Loading

0 comments on commit 901a6e2

Please sign in to comment.