Remove shadowed kol-span component

public-ui · Jul 19, 2024 · 9eff307 · 9eff307
2 parents c134b7a + e16f4c2
commit 9eff307
Show file tree

Hide file tree

Showing 6 changed files with 5 additions and 72 deletions.
diff --git a/packages/components/src/components/component-list.ts b/packages/components/src/components/component-list.ts
@@ -45,7 +45,6 @@ import { KolProcess } from './progress/shadow';
 import { KolQuote } from './quote/shadow';
 import { KolSelect } from './select/shadow';
 import { KolSkipNav } from './skip-nav/shadow';
-import { KolSpan } from './span/shadow';
 import { KolSpanWc } from './span/component';
 import { KolSpin } from './spin/shadow';
 import { KolSplitButton } from './split-button/shadow';
@@ -112,7 +111,6 @@ export const COMPONENTS = [
 	KolQuote,
 	KolSelect,
 	KolSkipNav,
-	KolSpan,
 	KolSpanWc,
 	KolSpin,
 	KolSplitButton,

diff --git a/packages/components/src/components/span/shadow.tsx b/packages/components/src/components/span/shadow.tsx
diff --git a/packages/components/src/components/span/test/html.mock.ts b/packages/components/src/components/span/test/html.mock.ts
@@ -38,7 +38,7 @@ export const getSpanWcHtml = (
 
 	const hideExpertSlot = !showExpertSlot(state._label);
 	const icon = mapIconProp2State(state._icons as KoliBriIconsProp);
-	const classNames: string[] = [...(state._hideLabel === true ? [`hide-label`] : []), ...(options?.additionalClassNames ?? [])];
+	const classNames: string[] = ['kol-span-wc', ...(state._hideLabel === true ? [`hide-label`] : []), ...(options?.additionalClassNames ?? [])];
 
 	return `
 <kol-span-wc${classNames.length ? ` class="${classNames.join(' ')}"` : ``}${options?.additionalAttrs ?? ''}>
@@ -84,17 +84,3 @@ export const getSpanWcHtml = (
 	}
 </kol-span-wc>`;
 };
-
-export const getSpanHtml = (
-	props: SpanProps,
-	slots: Slots = {
-		expert: `<slot name="expert" slot="expert"></slot>`,
-	},
-): string => {
-	return `
-<kol-span>
-	<mock:shadow-root>
-		${getSpanWcHtml(props, slots, { additionalClassNames: ['kol-span', 'kol-span-wc'] })}
-	</mock:shadow-root>
-</kol-span>`;
-};
diff --git a/packages/components/src/components/span/test/snapshot.spec.tsx b/packages/components/src/components/span/test/snapshot.spec.tsx
@@ -3,19 +3,17 @@ import { executeTests } from 'stencil-awesome-test';
 import { h } from '@stencil/core';
 import { newSpecPage } from '@stencil/core/testing';
 
-import { getSpanHtml } from './html.mock';
-
 import type { SpecPage } from '@stencil/core/testing';
 import type { SpanProps } from '../../../schema';
-import { KolSpan } from '../shadow';
 import { KolSpanWc } from '../component';
+import { getSpanWcHtml } from './html.mock';
 
 executeTests<SpanProps>(
 	'Span',
 	async (props): Promise<SpecPage> => {
 		const page = await newSpecPage({
-			components: [KolSpan, KolSpanWc],
-			template: () => <kol-span {...props} />,
+			components: [KolSpanWc],
+			template: () => <kol-span-wc {...props} />,
 		});
 		return page;
 	},
@@ -24,7 +22,7 @@ executeTests<SpanProps>(
 		_hideLabel: [true, false],
 		_label: ['Text', ''],
 	},
-	getSpanHtml,
+	getSpanWcHtml,
 	{
 		execMode: 'default', // ready
 	},

diff --git a/packages/components/src/core/component-names.ts b/packages/components/src/core/component-names.ts
@@ -45,7 +45,6 @@ export let KolProgressTag = 'kol-progress' as const;
 export let KolQuoteTag = 'kol-quote' as const;
 export let KolSelectTag = 'kol-select' as const;
 export let KolSkipNavTag = 'kol-skip-nav' as const;
-export let KolSpanTag = 'kol-span' as const;
 export let KolSpanWcTag = 'kol-span-wc' as const;
 export let KolSpinTag = 'kol-spin' as const;
 export let KolSplitButtonTag = 'kol-split-button' as const;
@@ -113,7 +112,6 @@ export const setCustomTagNames = (transformTagName: (tagName: string) => string)
 	KolQuoteTag = transformTagName(KolQuoteTag as string) as 'kol-quote';
 	KolSelectTag = transformTagName(KolSelectTag as string) as 'kol-select';
 	KolSkipNavTag = transformTagName(KolSkipNavTag as string) as 'kol-skip-nav';
-	KolSpanTag = transformTagName(KolSpanTag as string) as 'kol-span';
 	KolSpanWcTag = transformTagName(KolSpanWcTag as string) as 'kol-span-wc';
 	KolSpinTag = transformTagName(KolSpinTag as string) as 'kol-spin';
 	KolSplitButtonTag = transformTagName(KolSplitButtonTag as string) as 'kol-split-button';

diff --git a/packages/components/stencil.config.ts b/packages/components/stencil.config.ts
@@ -77,7 +77,6 @@ const EXCLUDE_TAGS = [
 	'kol-input',
 	'kol-link-wc',
 	'kol-popover-wc',
-	'kol-span',
 	'kol-span-wc',
 	'kol-table-stateless-wc',
 	'kol-tooltip-wc',