Fix expert slot activation with empty label string for button and link.

public-ui · Oct 16, 2023 · a3c54ab · a3c54ab
1 parent f275d04
commit a3c54ab
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/packages/components/src/components/button/component.tsx b/packages/components/src/components/button/component.tsx
@@ -397,7 +397,7 @@ export class KolButtonWc implements API {
 		this.validateIcons(this._icons || this._icon);
 		this.validateIconAlign(this._iconAlign);
 		this.validateId(this._id);
-		this.validateLabel(this._label || this._ariaLabel);
+		this.validateLabel(this._label ?? this._ariaLabel); // explicitly allow empty string labels
 		this.validateName(this._name);
 		this.validateOn(this._on);
 		this.validateRole(this._role);

diff --git a/packages/components/src/components/link/component.tsx b/packages/components/src/components/link/component.tsx
@@ -468,7 +468,7 @@ export class KolLinkWc implements API {
 		this.validateHref(this._href);
 		this.validateIcon(this._icons || this._icon);
 		this.validateIconAlign(this._iconAlign);
-		this.validateLabel(this._label || this._ariaLabel);
+		this.validateLabel(this._label ?? this._ariaLabel); // explicitly allow empty string labels
 		this.validateListenAriaCurrent(this._listenAriaCurrent);
 		this.validateOn(this._on);
 		this.validateRole(this._role);