Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐞 Bug: Input Error Message renders Alert Shadow DOM #6099

Closed
chriskrj opened this issue Feb 20, 2024 · 1 comment · Fixed by #6149
Closed

🐞 Bug: Input Error Message renders Alert Shadow DOM #6099

chriskrj opened this issue Feb 20, 2024 · 1 comment · Fixed by #6149
Assignees
@anicyne
Labels
bug Something isn't working good first issue Good for newcomers v2

Comments

@chriskrj
Copy link

Note

  • Ich achte beim Erstellen des Issues darauf, dass ich keine fachlichen und unternehmensinternen Details preisgebe.

Fehlermeldung

Beschreibung des Fehlers

Bildschirmfoto 2024-02-20 um 16 18 22

Zusätzlicher Kontext

Es besteht keine Möglichkeit, die angezeigte Fehlermeldung individuell zu stylen. Siehe #5102 @deleonio
@chriskrj chriskrj added the bug Something isn't working label Feb 20, 2024
@deleonio
Copy link
Contributor

deleonio commented Feb 21, 2024 •
edited
Loading

Innerhalb von KoliBri-Komponenten werden keine erneuten Shadow-Roots verwendet, um die Gestaltbarkeit zu vereinfachen.

Hier müssen alle Inputs, Select und Textarea so refactored werden, dass sie statt der kol-alert direkt die kol-alert-wc verwenden.

  • kol-alert gegen kol-alert-wc austauschen (Inputs, Select, Textarea)
  • Themes anpassen (Mixins nutzen)

@deleonio deleonio added v2 good first issue Good for newcomers labels Feb 21, 2024
@deleonio deleonio moved this to 📄 Ready in KoliBri Board Feb 22, 2024
@anicyne anicyne self-assigned this Feb 26, 2024
@anicyne anicyne moved this from 📄 Ready to 🏗 In progress in KoliBri Board Feb 26, 2024
@anicyne anicyne linked a pull request Mar 1, 2024 that will close this issue
Fix: Replace kol-alert with kol-alert-wc in Input Error Message #6149
Merged
6 tasks
@anicyne anicyne moved this from 🏗 In progress to 🔍 Review in KoliBri Board Mar 1, 2024
@github-project-automation github-project-automation bot moved this from 🔍 Review to ✅ Done in KoliBri Board Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anicyne anicyne

Labels
bug Something isn't working good first issue Good for newcomers v2
Projects
KoliBri Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: Replace kol-alert with kol-alert-wc in Input Error Message public-ui/kolibri
3 participants
@deleonio @chriskrj @anicyne