Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Replace kol-alert with kol-alert-wc in Input Error Message #6149

Merged
merged 7 commits into from
Mar 7, 2024
Merged

Fix: Replace kol-alert with kol-alert-wc in Input Error Message #6149

merged 7 commits into from
Mar 7, 2024

Conversation

anicyne
Copy link
Contributor

@anicyne anicyne commented Mar 1, 2024 •
edited by deleonio
Loading

☑️ Definition of Done checklist

  • Meaningful title for the release notes
  • Pull request is linked to an issue
  • All changes relate to the issue
  • A11y tests performed successfully
  • Code review carried out successfully
  • Manual test performed successfully

@anicyne anicyne self-assigned this Mar 1, 2024
@anicyne anicyne linked an issue Mar 1, 2024 that may be closed by this pull request
🐞 Bug: Input Error Message renders Alert Shadow DOM #6099
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 1, 2024 •
edited
Loading

Netlify Draft Deployment
URL: https://65e9ee84837adc2fd4515a3d--kolibri-public-ui.netlify.app
Logs: https://app.netlify.com/sites/kolibri-public-ui/deploys/65e9ee84837adc2fd4515a3d

@deleonio deleonio self-requested a review March 4, 2024 06:36
@deleonio
Copy link
Contributor

deleonio commented Mar 6, 2024

@anicyne dieser PR war abhängig von dem tag classes PR. Bitte noch einmal anpassen.

@anicyne anicyne requested a review from deleonio March 7, 2024 10:35
@anicyne anicyne removed the conflict label Mar 7, 2024
@deleonio
remove duplicate .msg
5db8d13 
Signed-off-by: Martin <6279703+deleonio@users.noreply.github.com>
deleonio
deleonio previously approved these changes Mar 7, 2024
View reviewed changes
@deleonio
Update index.ts
2b060fa 
Signed-off-by: Martin <6279703+deleonio@users.noreply.github.com>
@deleonio deleonio merged commit 2ae7767 into develop Mar 7, 2024
3 of 4 checks passed
@deleonio deleonio deleted the v2/6099_input-error-shadow-dom branch March 7, 2024 16:45
@github-actions github-actions bot locked and limited conversation to collaborators Mar 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sdvg sdvg sdvg left review comments

@deleonio deleonio deleonio left review comments

Assignees

@anicyne anicyne

Labels
None yet
Projects
KoliBri Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐞 Bug: Input Error Message renders Alert Shadow DOM
3 participants
@anicyne @deleonio @sdvg