Call onClose callback when Modal gets closed #5420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdvg
commented
Oct 9, 2023
| export type KoliBriModalEventCallbacks = { | ||
| onClose?: EventCallback<Event>; | ||
| onClose?: () => void; |
There was a problem hiding this comment.
Event bzw. EventCallback benötigt immer ein Event Parameter, das wir hier nicht haben, wenn das Modal von "außen" geschlossen wurde.
There was a problem hiding this comment.
Man könnte ein eigenes Event erzeugen. So wird es z. B. in der Card gemacht:
this._on.onClose(new Event('Close'));
laske185
requested changes
Oct 16, 2023
| export type KoliBriModalEventCallbacks = { | ||
| onClose?: EventCallback<Event>; | ||
| onClose?: () => void; |
There was a problem hiding this comment.
Man könnte ein eigenes Event erzeugen. So wird es z. B. in der Card gemacht:
this._on.onClose(new Event('Close'));
deleonio
deleted the
5395-bug-wenn-ein-modal-per-esc-geschlossen-wird-kann-es-nicht-noch-einmal-geöffnet-werden
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.