Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: details missing aria hidden #5530

Merged
merged 2 commits into from
Nov 6, 2023
Merged

fix: details missing aria hidden #5530

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8d9ae3f
fix: details missing aria hidden
deleonio Nov 6, 2023
12c01cb
fix: test mock
deleonio Nov 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/components/src/components/details/component.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ export class KolDetails implements API {
{this.state._open ? <kol-icon _label="" _icons="codicon codicon-chevron-down" /> : <kol-icon _label="" _icons="codicon codicon-chevron-right" />}
<span>{this.state._label}</span>
</summary>
<div class="content" ref={(element) => (this.contentElement = element)}>
<div aria-hidden={this.state._open === false ? 'true' : undefined} class="content" ref={(element) => (this.contentElement = element)}>
<kol-indented-text>
<slot />
</kol-indented-text>
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/components/details/test/html.mock.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ export const getDetailsHtml = (
${props._label! /* TODO v2: Remove non-null assertion after label was converted to required prop */}
</span>
</summary>
<div class="content">
<div${props._open ? `` : ` aria-hidden="true"`} class="content">
${getIndentedTextHtml(props, slots)}
</div>
</details>
Expand Down
Loading