fix: checkbox button semantic #5654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 28, 2023
…ix/checkbox-button-semantic-v2
sdvg
reviewed
Nov 28, 2023
| } | ||
|
|
||
| .button input { | ||
| display: none; | ||
| border: none !important; |
There was a problem hiding this comment.
Ich vermute das wird an der Stelle so gut funktionieren, ich hätte trotzdem ein paar Anmerkungen:
- Ich fände es gut, klar zu machen was hier passiert - über einen Kommentar oder noch besser indem wir diese Styles in einer utility-Klasse verschieben (
a11y.css,.visually-hidden?) - Die hier verwendete Technik kenne ich nicht, ich hatte in der Vergangenheit immer diesen Snippet verwendet und weiß, dass er sehr robust ist. Auch unabhängig von dem zu versteckenden Element.
- Brauchen wir die
!important-Deklarationen wirklich? Wir könnten auch sicher stellen, dass Themes die Styles nicht überschreiben, solche Styles wären dann sowieso redundant.
sdvg
approved these changes
Nov 28, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.