Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug/schlechter oder kein umbruch bei vergoesserung #5719

Merged
merged 30 commits into from
Jan 3, 2024
Merged

Bug/schlechter oder kein umbruch bei vergoesserung #5719

merged 30 commits into from
Jan 3, 2024

Conversation

anicyne
Copy link
Contributor

@anicyne anicyne commented Dec 7, 2023

@netlify Netlify
Copy link

netlify bot commented Dec 7, 2023 •
edited
Loading

✅ Deploy Preview for kolibri-public-ui ready!

Name Link
🔨 Latest commit a3eaa9c
🔍 Latest deploy log https://app.netlify.com/sites/kolibri-public-ui/deploys/6573165a1d97e4000882b2fa
😎 Deploy Preview https://deploy-preview-5719--kolibri-public-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 7, 2023 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@sdvg sdvg self-requested a review December 7, 2023 15:36
deleonio
deleonio requested changes Dec 8, 2023
View reviewed changes
Copy link
Contributor

@deleonio deleonio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI @sdvg

packages/themes/default/src/index.ts Outdated Show resolved Hide resolved
packages/samples/react/src/style.scss Outdated Show resolved Hide resolved
packages/samples/react/src/components/table/render-cell.tsx Outdated Show resolved Hide resolved
packages/samples/react/src/components/table/badge-size.tsx Outdated Show resolved Hide resolved
packages/samples/react/src/components/link-button/basic.tsx Outdated Show resolved Hide resolved
packages/samples/react/src/components/card/selection.tsx Outdated Show resolved Hide resolved
packages/samples/react/src/components/button/width.tsx Outdated Show resolved Hide resolved
packages/samples/react/src/components/button/access-key.tsx Outdated Show resolved Hide resolved
packages/components/src/components/table/style.css Show resolved Hide resolved
@deleonio
Copy link
Contributor

deleonio commented Dec 8, 2023

Vielen Dank für den PR @cyrinermd.

sdvg
sdvg requested changes Dec 8, 2023
View reviewed changes
packages/themes/default/src/index.ts Outdated Show resolved Hide resolved
packages/components/src/components/table/style.css Outdated Show resolved Hide resolved
@anicyne
Copy link
Contributor Author

anicyne commented Dec 8, 2023

I have read the CLA Document and I hereby sign the CLA

deleonio
deleonio requested changes Dec 14, 2023
View reviewed changes
packages/themes/default/src/index.ts Outdated Show resolved Hide resolved
packages/samples/react/src/style.scss Outdated Show resolved Hide resolved
packages/components/src/components/table/style.css Outdated Show resolved Hide resolved
@sdvg sdvg linked an issue Dec 14, 2023 that may be closed by this pull request
🐞 Bug: 9.1.4.10 Schlechter oder kein Umbruch bei Vergrößerung #5628
Closed
@sdvg
Copy link
Member

sdvg commented Dec 15, 2023

@cyrinermd Der Build schläge aktuell wegen Formatting fehl, könntest du mal schauen und die Sachen beheben?

@deleonio Ich habe den Stand einmal zum Testen hier deployed: https://657c5aa9cd3a0517c545e909--kol-test.netlify.app/#/table/with-pagination

Passt das so schon oder sollten wir die "responsiveness" speziell für die Tabellen-Paginierung vielleicht noch weiter verbessern?

Ideal fände ich eigentlich, wenn diese drei Gruppen in neue Zeilen umbrechen, bevor innerhalb der Gruppen umgebrochen wird:
image
Das ist aktuell noch nicht der Fall. Außerdem würde ich vorschlagen, die Implementierung unabhängig von Media-Queries zu machen, da wir nicht wissen, wie breit die Container sein werden, in denen die Table verwendet wird.
Das könnte man aber auch in einem neuen Ticket angehen.

@deleonio deleonio changed the base branch from develop to bug/schlechter-oder-kein-umbruch-bei-vergoesserung December 22, 2023 05:23
@anicyne
Merge branch 'develop' of https://github.com/cyrinermd/kolibri into b…
206b35d 
…ug/schlechter-oder-kein-umbruch-bei-vergoesserung
@sdvg sdvg merged commit 5d0fd53 into public-ui:bug/schlechter-oder-kein-umbruch-bei-vergoesserung Jan 3, 2024
1 of 3 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@deleonio deleonio deleonio requested changes

@sdvg sdvg sdvg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐞 Bug: 9.1.4.10 Schlechter oder kein Umbruch bei Vergrößerung
3 participants
@anicyne @deleonio @sdvg