Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: component loading for vite esm #5794

Merged
merged 1 commit into from
Dec 19, 2023
Merged

Conversation

deleonio
Copy link
Contributor

@deleonio deleonio commented Dec 19, 2023

Durch die Aktivierung einiger Stencil-Extras könnten sich einige Nutzungsszenarien verbessern. Wie seht Ihr das?

FYI: @sdvg, @laske185

@deleonio deleonio linked an issue Dec 19, 2023 that may be closed by this pull request
@deleonio deleonio requested review from sdvg and laske185 December 19, 2023 05:00
packages/samples/angular/package.json Outdated Show resolved Hide resolved
packages/components/stencil.config.ts Outdated Show resolved Hide resolved
packages/components/stencil.config.ts Outdated Show resolved Hide resolved
packages/components/stencil.config.ts Outdated Show resolved Hide resolved
packages/components/stencil.config.ts Outdated Show resolved Hide resolved
packages/components/stencil.config.ts Outdated Show resolved Hide resolved
packages/components/stencil.config.ts Outdated Show resolved Hide resolved
packages/components/stencil.config.ts Outdated Show resolved Hide resolved
@sdvg
Copy link
Member

sdvg commented Dec 19, 2023

Ich find die experimentalSlotFixes grundsätzlich interessant, für die anderen Optionen sehe ich auch keinen Bedarf.

Als ich das letzte mal an Slot-Problemen gearbeitet habe, haben die experimental slot fixes allerdings [noch] nicht geholfen. Ich würde mir die Option merken und erneut testen, wenn wir noch einmal auf konkrete Probleme mit den Slots stoßen (z.B. bei so einem Ticket: #5735).

@deleonio deleonio force-pushed the fix/component-loading-vite-esm branch from fd0cde3 to 329039b Compare December 19, 2023 14:22
@deleonio deleonio merged commit 73cb16a into develop Dec 19, 2023
2 of 3 checks passed
@deleonio deleonio deleted the fix/component-loading-vite-esm branch December 19, 2023 14:23
@github-actions github-actions bot locked and limited conversation to collaborators Dec 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🛹 Feature: Lazy loaded web components mit vite
3 participants