Improve nav component #5833
Merged
Improve nav component #5833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Netlify Draft Deployment |
A new mixin, `focus-outline`, has been created to standardize the look, color, and transition of focus outlines across multiple components. This will ensure consistency and ease future changes, as they only need to be made in one place. The mixin has been implemented in `button`, `input-checkbox`, `pagination` and `accordion` components.
…nav-default-theme-muss-valide-gestyled-werden * 'develop' of github.com:public-ui/kolibri: (37 commits) make it better fix: pagination validation fix: pagination validation fix: tests fix: tests chore: remove comment lines fix: optimize prop validation fix: optimize prop validation fix: prop validation for testing optimized chore: release 2.0.3 fix: tests chore: update deps and lock build: update generated component readmes build: deploy action builds only necessary packages fix: adopted-style-sheets dependency refact: remove th theme fix: tests fix: tooltips arrow position Fix condition for external links hint Update all snapshots ...
…valide-gestyled-werden' into 5810-bug-nav-default-theme-muss-valide-gestyled-werden * origin/5810-bug-nav-default-theme-muss-valide-gestyled-werden: Update all snapshots
laske185
requested changes
Jan 8, 2024
packages/themes/bmf/snapshots/theme-bmf/snapshot-for-handout-basic-firefox-linux.png
Outdated
Show resolved
Hide resolved
packages/themes/bmf/snapshots/theme-bmf/snapshot-for-nav-aria-current-firefox-linux.png
Outdated
Show resolved
Hide resolved
laske185
approved these changes
Jan 8, 2024
laske185
deleted the
5810-bug-nav-default-theme-muss-valide-gestyled-werden
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.