Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add disabled to accordion, details and links too #5981

Merged
merged 21 commits into from
Feb 12, 2024
Merged

feat: add disabled to accordion, details and links too #5981

merged 21 commits into from
Feb 12, 2024

Conversation

deleonio
Copy link
Contributor

@deleonio deleonio commented Jan 30, 2024 •
edited
Loading

Das war ein Entwurf 😄 - Danke für die fruchtbaren Debatten.

☑️ Definition of Done checklist

  • Meaningful title and valuable description in pull request
  • Pull request linked to one or more issues
    • Acceptance criteria of the linked issue satisfied
    • All changes relates to the issue
  • All tests passed
    • Code changes tested manually if not covered by automated tests
    • A11y tests successful carried out

@deleonio deleonio force-pushed the feature/aria-disabled-instead-of-disabled branch from 926920c to e37c100 Compare January 30, 2024 09:49
@deleonio deleonio marked this pull request as draft January 30, 2024 09:50
@deleonio deleonio linked an issue Jan 30, 2024 that may be closed by this pull request
🛹 Feature: aria-disabled=true, remove disabled and cancel click-Event #5975
Closed
10 tasks
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 30, 2024 •
edited
Loading

Netlify Draft Deployment
URL: https://65ca312165c07d007d3fdeeb--kolibri-public-ui.netlify.app
Logs: https://app.netlify.com/sites/kolibri-public-ui/deploys/65ca312165c07d007d3fdeeb

@deleonio deleonio force-pushed the feature/aria-disabled-instead-of-disabled branch 3 times, most recently from 8090dba to 7f03db9 Compare January 30, 2024 10:35
@deleonio deleonio force-pushed the feature/aria-disabled-instead-of-disabled branch 2 times, most recently from da2d442 to 5c5e297 Compare February 1, 2024 06:24
@deleonio deleonio marked this pull request as ready for review February 1, 2024 07:06
@deleonio deleonio requested review from sdvg, laske185 and AntnSaj and removed request for AntnSaj February 1, 2024 07:06
@deleonio deleonio mentioned this pull request Feb 1, 2024
Closed
@AntnSaj
Copy link

AntnSaj commented Feb 2, 2024

Bei den Komponenten Accordeon, Details und link verändert sich der Mauscursor beim hovern. Dies lässt darauf schließen, dass das Element anklickbar ist.

Weiterhin wird bei den Elementen Details und link nicht deutlich, dass es sich um ein disabled Element handelt. Die disabled Elemente unterscheiden sich visuell nicht von den aktiven Elementen.

@deleonio deleonio force-pushed the feature/aria-disabled-instead-of-disabled branch 2 times, most recently from d2dd448 to 7d443ca Compare February 6, 2024 06:51
@deleonio deleonio force-pushed the feature/aria-disabled-instead-of-disabled branch from 7d443ca to 5cbe84c Compare February 6, 2024 06:57
@deleonio deleonio requested a review from AntnSaj February 6, 2024 06:58
@deleonio
Copy link
Contributor Author

deleonio commented Feb 6, 2024

@AntnSaj: Ich habe das Styling überarbeitet.

@AntnSaj
Copy link

AntnSaj commented Feb 7, 2024

Accordeon und Details passt soweit. Der disabled Link wird beim hovern noch fett unterstrichen.

@deleonio deleonio force-pushed the feature/aria-disabled-instead-of-disabled branch from 23d9c0f to ee26b61 Compare February 9, 2024 05:05
@deleonio deleonio enabled auto-merge February 9, 2024 14:41
sdvg
sdvg reviewed Feb 9, 2024
View reviewed changes
packages/components/src/components/link.css Outdated Show resolved Hide resolved
packages/themes/bmf/src/index.ts Outdated Show resolved Hide resolved
@deleonio deleonio requested a review from sdvg February 12, 2024 10:50
sdvg
sdvg requested changes Feb 12, 2024
View reviewed changes
packages/components/src/components/details/component.tsx Outdated Show resolved Hide resolved
packages/components/src/components/link/component.tsx Outdated Show resolved Hide resolved
packages/components/src/components/style.css Outdated Show resolved Hide resolved
packages/components/src/components/style.css Outdated Show resolved Hide resolved
packages/components/stencil.config.ts Outdated Show resolved Hide resolved
packages/themes/bmf/src/index.ts Show resolved Hide resolved
@deleonio deleonio requested review from sdvg and removed request for AntnSaj, sdvg and laske185 February 12, 2024 15:24
@deleonio deleonio merged commit b710c74 into develop Feb 12, 2024
5 checks passed
@deleonio deleonio deleted the feature/aria-disabled-instead-of-disabled branch February 12, 2024 15:34
@github-actions github-actions bot locked and limited conversation to collaborators Feb 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sdvg sdvg sdvg approved these changes

Assignees
No one assigned
Labels
v2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🛹 Feature: aria-disabled=true, remove disabled and cancel click-Event
3 participants
@deleonio @AntnSaj @sdvg