Normalize change and input events across all input components #6233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before some components emitted `change` on keyup and `input` did not exist. The KoliBri `change` and `input` events and callbacks now correctly reflect the native DOM behaviour.
|
Netlify Draft Deployment |
deleonio
requested changes
Mar 22, 2024
| @@ -1,5 +1,5 @@ | |||
| // TODO: Should be synchronized with enums/events.ts | |||
| type KoliBriEventType = 'blur' | 'change' | 'click' | 'focus' | 'toggle'; | |||
| type KoliBriEventType = 'blur' | 'change' | 'click' | 'focus' | 'toggle' | 'input'; | |||
There was a problem hiding this comment.
Bitte hier alphabetisch einsortieren. Danke
deleonio
approved these changes
Mar 22, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before some components emitted
changeon keyup andinputdid not exist. The KoliBrichangeandinputevents and callbacks now correctly reflect the native DOM behaviour.☑️ Definition of Done checklist