Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progress bar: Allow dynamic SVG width, refactor, make <text> part of the SVG #6238

Merged
merged 12 commits into from
Mar 26, 2024

Conversation

sdvg
Copy link
Member

@sdvg sdvg commented Mar 21, 2024

  • <text> ist jetzt Teil des SVG (siehe text-Tag im Progress Bar ist außerhalb des SVG-Tags #6141)
  • Die Breite des progress SVG kann jetzt dynamisch gesetzt werden, der Inhalt passt sich automatisch an die Breite an.
    • Falls notwendig kann der reservierte Platz für das Text-Label mit der Custom Property --kolibri-text-label-padding angepasst werden (siehe ITZ-Theme).
  • An der cycle-Variante habe ich nichts geändert, diese skaliert bereits einwandfrei. Eine einseitige Skalierung in die Breite fände ich hier nicht sinnvoll.
  • Folgende zwei Varianten habe ich entfernt, da sie (soweit für mich nachvollziehbar) nicht genutzt wurden:
    • cycle-value-label
    • cycle-label-value

☑️ Definition of Done checklist

  • Meaningful title for the release notes
  • Pull request is linked to a problem
  • All changes relate to the problem
  • Code review performed successfully
  • A11y tests performed successfully or not relevant
  • Manual test performed successfully or not relevant

@sdvg sdvg linked an issue Mar 21, 2024 that may be closed by this pull request
Copy link
Contributor

github-actions bot commented Mar 21, 2024

sdvg and others added 8 commits March 21, 2024 14:51
…gress-svg

* origin/5239-progress-svg:
  Update all snapshots
…ress-svg

* 'develop' of github.com:public-ui/kolibri: (47 commits)
  Bump contributor-assistant/github-action from 2.3.1 to 2.3.2
  chore: update readme.md
  chore: fix anonymous.js
  chore: release 2.0.10
  fix: lint typing theme
  Update all snapshots
  chore: update deps and lock
  Update custom.tsx
  Überarbeitete Description für Spin Custom #6059
  Update DoD
  CI pipeline: Include test-tag-name-transformer results in uploaded artefacts
  Update all snapshots
  Add message type classnames to kol-input
  Update all snapshots
  Update all snapshots
  Nav: Allow click events on button entries. Setting a click callback overrides the "toggle expansion" functionality.
  Update Readmes and fix random type error
  Remove complex-form Route
  add new ''input-radio/object" route
  Corrected "li" to "ol"
  ...
@sdvg sdvg marked this pull request as ready for review March 25, 2024 08:08
@sdvg sdvg linked an issue Mar 25, 2024 that may be closed by this pull request
@sdvg sdvg added the v2 label Mar 25, 2024
@deleonio deleonio marked this pull request as draft March 26, 2024 12:08
@deleonio deleonio marked this pull request as ready for review March 26, 2024 12:08
@deleonio deleonio self-requested a review March 26, 2024 12:08
@deleonio deleonio merged commit 754ec4e into develop Mar 26, 2024
5 of 7 checks passed
@deleonio deleonio deleted the 5239-progress-svg branch March 26, 2024 14:52
@github-actions github-actions bot locked and limited conversation to collaborators Mar 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

text-Tag im Progress Bar ist außerhalb des SVG-Tags 📖 Help: KolProgress - Breite nicht flexibel
2 participants