Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply BEM refactoring to progress, popover and nav #7137

Merged
merged 34 commits into from
Dec 19, 2024
Merged

Apply BEM refactoring to progress, popover and nav #7137

merged 34 commits into from
Dec 19, 2024

Conversation

anicyne
Copy link
Contributor

@anicyne anicyne commented Nov 28, 2024 •
edited
Loading

Refs: #7036

The A11y and PO reviews will only take place after all other DoD steps have been completed by the Developer:

  • Meaningful pull request title for the release notes
  • Pull request is linked to an issue and all changes relate to the issue
  • Tests to protect this code implemented (if applicable)
  • Manual test performed successfully (if applicable)
  • Documentation or migration has been updated (if applicable)

@anicyne anicyne marked this pull request as draft November 28, 2024 16:22
@anicyne anicyne linked an issue Nov 28, 2024 that may be closed by this pull request
BEM-Refactoring #7036
Open
55 tasks
@anicyne anicyne mentioned this pull request Nov 28, 2024
Open
55 tasks
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 28, 2024 •
edited
Loading

Netlify Draft Deployment
URL: https://6764546b43e3a000924820eb--kolibri-public-ui.netlify.app
Logs: https://app.netlify.com/sites/kolibri-public-ui/deploys/6764546b43e3a000924820eb

@anicyne anicyne added the v3 Here are issues that need to be resolved for version 3. label Nov 28, 2024
@anicyne anicyne force-pushed the 7036-bem-refactoring-progress-popover-nav branch from cb1fec6 to 8a4623d Compare December 2, 2024 09:28
@anicyne anicyne force-pushed the 7036-bem-refactoring-progress-popover-nav branch from ca7b88b to 284ed8a Compare December 2, 2024 14:17
@anicyne anicyne force-pushed the 7036-bem-refactoring-progress-popover-nav branch from 1313106 to 340d80f Compare December 2, 2024 14:32
@anicyne anicyne force-pushed the 7036-bem-refactoring-progress-popover-nav branch from b5fbfd2 to ac5aca9 Compare December 2, 2024 15:03
@anicyne anicyne force-pushed the 7036-bem-refactoring-progress-popover-nav branch from 3519aad to 9313e86 Compare December 2, 2024 15:32
@anicyne anicyne force-pushed the 7036-bem-refactoring-progress-popover-nav branch 2 times, most recently from 4e36ff3 to 1e0a407 Compare December 3, 2024 08:30
@anicyne anicyne force-pushed the 7036-bem-refactoring-progress-popover-nav branch from 1e0a407 to dbe08f5 Compare December 3, 2024 08:35
@anicyne anicyne marked this pull request as ready for review December 3, 2024 11:21
@anicyne anicyne marked this pull request as ready for review December 9, 2024 16:14
@anicyne anicyne marked this pull request as draft December 11, 2024 07:37
@anicyne anicyne force-pushed the 7036-bem-refactoring-progress-popover-nav branch from 2fcc100 to 34b0f86 Compare December 16, 2024 12:42
@anicyne anicyne force-pushed the 7036-bem-refactoring-progress-popover-nav branch from d5ef57b to d4a6f7b Compare December 16, 2024 13:02
@anicyne anicyne force-pushed the 7036-bem-refactoring-progress-popover-nav branch from 19d56d5 to 8dc413e Compare December 16, 2024 14:28
@anicyne anicyne marked this pull request as ready for review December 16, 2024 15:26
@anicyne anicyne requested a review from sdvg December 16, 2024 15:26
sdvg
sdvg requested changes Dec 16, 2024
View reviewed changes
Copy link
Member

@sdvg sdvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hallo @anicyne, ich habe mich hier auch erst einmal nur auf die HTML-Struktur konzentriert. Das restliche CSS würde ich reviewen, wenn das angepasst ist.

packages/components/src/components/nav/shadow.tsx Outdated Show resolved Hide resolved
packages/components/src/components/nav/shadow.tsx Outdated Show resolved Hide resolved
packages/components/src/components/nav/shadow.tsx Outdated Show resolved Hide resolved
packages/components/src/components/nav/shadow.tsx Outdated Show resolved Hide resolved
packages/components/src/components/nav/style.scss Outdated Show resolved Hide resolved
packages/components/src/components/popover/component.tsx Outdated Show resolved Hide resolved
packages/components/src/components/progress/shadow.tsx Outdated Show resolved Hide resolved
sdvg added 7 commits December 18, 2024 11:36
@sdvg
Merge branch 'develop' of github.com:public-ui/kolibri into 7036-bem-…
c445fca 
…refactoring-progress-popover-nav

* 'develop' of github.com:public-ui/kolibri: (76 commits)
  review fixes
  chore: update deps and lock
  Update all snapshots$ $ Refs: #7032
  fixed typo
  Update CONTRIBUTING.md for new branches
  bem refactor
  removed wrong selector
  bem refactor
  Update all snapshots$ $ Refs: #7032
  Revert "Update all snapshots$"
  style: adjust input adornments and button properties for better layout
  Update all snapshots$ $ Refs: #7032
  Revert "Update all snapshots$"
  style: adjust gap for kol-input in input-range component
  Update all snapshots$ $ Refs: #7032
  Revert "Update all snapshots$"
  style: adjust gap in input styles and improve message handling in FormField component
  Update all snapshots$ $ Refs: #7032
  Revert "Update all snapshots$"
  style: remove unnecessary padding from input elements in input-core.scss
  ...
@sdvg
Rework nav
351f204 
Refs: #7036
@sdvg
Fix popover arrow modifier classname
8cda61c 
Refs: #7036
@sdvg
Fix progress BEM and styles
cb9cfa1 
Refs: #7036
@sdvg
Merge branch 'develop' of github.com:public-ui/kolibri into 7036-bem-…
62139d0 
…refactoring-progress-popover-nav

* 'develop' of github.com:public-ui/kolibri:
  Fix typo
  Document breaking changes
  Remove deprecated properties alert and error from all input components
  Remove deprecated property alert from combobox
@sdvg
Convert progress to snapshot tests
526b511 
Refs: #7036
@sdvg
Fix selector
b6ee073 
Refs: #7036
@sdvg sdvg requested review from sdvg and removed request for sdvg December 18, 2024 15:41
@sdvg
Merge branch 'develop' of github.com:public-ui/kolibri into 7036-bem-…
e773c05 
…refactoring-progress-popover-nav

* 'develop' of github.com:public-ui/kolibri: (94 commits)
  style fix
  fixed wrong classname
  fixed footer background
  bem refactor toast
  Replace remaining sort usages
  Remove deprecated toast property alertVariant
  Remove deprecated table header propery `sort`
  Remove property activeElement from modal
  Update all snapshots$ $ Refs: #7015
  Removed now unused data module
  Remove deprecated component KolTable and rewrite samples to KolTableStateful
  Update docs
  Make value prop optional because of KolInputFile
  Remove _file reflection
  Remove deprecated focus methods
  Remove deprecated component KolLogo
  Remove deprecated component KolLinkGroup
  Remove deprecated component KolIndentedText
  Remove leftover buttonGroup reference
  Remove deprecated component KolButtonGroup
  ...
@deleonio deleonio merged commit c8e4dfa into develop Dec 19, 2024
9 checks passed
@deleonio deleonio deleted the 7036-bem-refactoring-progress-popover-nav branch December 19, 2024 17:24
@github-actions github-actions bot locked and limited conversation to collaborators Dec 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sdvg sdvg sdvg requested changes

@deleonio deleonio deleonio approved these changes

Assignees
No one assigned
Labels
v3 Here are issues that need to be resolved for version 3.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BEM-Refactoring
3 participants
@anicyne @sdvg @deleonio