Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply BEM refactoring to Span & Heading #7154

Merged
merged 19 commits into from
Dec 9, 2024
Merged

Apply BEM refactoring to Span & Heading #7154

merged 19 commits into from
Dec 9, 2024

Conversation

AlexanderSchmidtCE
Copy link
Contributor

@AlexanderSchmidtCE AlexanderSchmidtCE commented Dec 5, 2024 •
edited
Loading

Refs: #7036

The A11y and PO reviews will only take place after all other DoD steps have been completed by the Developer:

  • Meaningful pull request title for the release notes
  • Pull request is linked to an issue and all changes relate to the issue
  • Tests to protect this code implemented (if applicable)
  • Manual test performed successfully (if applicable)
  • Documentation or migration has been updated (if applicable)

@AlexanderSchmidtCE AlexanderSchmidtCE changed the title changes kol-span-ws to kol-span Apply BEM refactoring to Span Dec 5, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 5, 2024 •
edited
Loading

Netlify Draft Deployment
URL: https://6756c44d8fe326dbe2a257c2--kolibri-public-ui.netlify.app
Logs: https://app.netlify.com/sites/kolibri-public-ui/deploys/6756c44d8fe326dbe2a257c2

@AlexanderSchmidtCE AlexanderSchmidtCE changed the title Apply BEM refactoring to Span Apply BEM refactoring to Span & Heading Dec 6, 2024
@AlexanderSchmidtCE AlexanderSchmidtCE mentioned this pull request Dec 6, 2024
Open
55 tasks
@AlexanderSchmidtCE AlexanderSchmidtCE marked this pull request as ready for review December 6, 2024 10:51
@AlexanderSchmidtCE AlexanderSchmidtCE linked an issue Dec 6, 2024 that may be closed by this pull request
BEM-Refactoring #7036
Open
55 tasks
@sdvg sdvg merged commit e90c9b0 into develop Dec 9, 2024
10 checks passed
@sdvg sdvg deleted the 7035-bem-refactor-span branch December 9, 2024 14:34
@github-actions github-actions bot locked and limited conversation to collaborators Dec 9, 2024
@deleonio deleonio added the v3 Here are issues that need to be resolved for version 3. label Dec 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sdvg sdvg sdvg approved these changes

Assignees
No one assigned
Labels
v3 Here are issues that need to be resolved for version 3.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BEM-Refactoring
3 participants
@AlexanderSchmidtCE @sdvg @deleonio