Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply BEM refactoring to tree, tree-item, toolbar and tooltip #7161

Merged
merged 15 commits into from
Dec 16, 2024
Merged

Apply BEM refactoring to tree, tree-item, toolbar and tooltip #7161

merged 15 commits into from
Dec 16, 2024

Conversation

anicyne
Copy link
Contributor

@anicyne anicyne commented Dec 6, 2024 •
edited
Loading

Refs: #7036

The A11y and PO reviews will only take place after all other DoD steps have been completed by the Developer:

  • Meaningful pull request title for the release notes
  • Pull request is linked to an issue and all changes relate to the issue
  • Tests to protect this code implemented (if applicable)
  • Manual test performed successfully (if applicable)
  • Documentation or migration has been updated (if applicable)

@anicyne anicyne marked this pull request as draft December 6, 2024 07:16
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 6, 2024 •
edited
Loading

Netlify Draft Deployment
URL: https://676025e6efc0ae2232e8d2d8--kolibri-public-ui.netlify.app
Logs: https://app.netlify.com/sites/kolibri-public-ui/deploys/676025e6efc0ae2232e8d2d8

@anicyne anicyne linked an issue Dec 6, 2024 that may be closed by this pull request
BEM-Refactoring #7036
Open
55 tasks
@anicyne anicyne mentioned this pull request Dec 9, 2024
Open
55 tasks
@deleonio deleonio added the v3 Here are issues that need to be resolved for version 3. label Dec 10, 2024
@anicyne anicyne force-pushed the 7036-BEM-Refactoring-tree-treeItem-Version-tooltip-toolbar branch from d07c9da to 4261fca Compare December 10, 2024 13:22
@anicyne
Merge branch 'develop' of https://github.com/public-ui/kolibri into 7…
0593962 
…036-BEM-Refactoring-tree-treeItem-Version-tooltip-toolbar
@anicyne
Merge branch '7036-BEM-Refactoring-tree-treeItem-Version-tooltip-tool…
ac06596 
…bar' of https://github.com/public-ui/kolibri into 7036-BEM-Refactoring-tree-treeItem-Version-tooltip-toolbar
@anicyne
Fix link padding in tree-item
3295093 
Refs: #7036
@anicyne anicyne force-pushed the 7036-BEM-Refactoring-tree-treeItem-Version-tooltip-toolbar branch 4 times, most recently from 8f4bdfc to ef372b1 Compare December 11, 2024 10:15
@anicyne anicyne force-pushed the 7036-BEM-Refactoring-tree-treeItem-Version-tooltip-toolbar branch from 3dddd10 to ec1e557 Compare December 11, 2024 10:27
@anicyne anicyne marked this pull request as ready for review December 11, 2024 10:41
@sdvg sdvg self-requested a review December 11, 2024 13:01
sdvg
sdvg requested changes Dec 11, 2024
View reviewed changes
Copy link
Member

@sdvg sdvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Ich habe bisher nur das Default-Theme angeschaut, weil sich die Änderungen danach wiederholen. Kommentare bitte auf alle Themes anwenden.
  • Könntest du aus dem PR-Titel bitte version entfernen? Da haben wir keine Änderungen gemacht.

packages/components/src/components/toolbar/shadow.tsx Outdated Show resolved Hide resolved
packages/components/src/components/tooltip/component.tsx Outdated Show resolved Hide resolved
packages/components/src/components/tree-item/component.tsx Outdated Show resolved Hide resolved
packages/components/src/components/tree-item/component.tsx Outdated Show resolved Hide resolved
packages/themes/default/src/components/tree-item.scss Outdated Show resolved Hide resolved
packages/themes/default/src/global.scss Outdated Show resolved Hide resolved
@anicyne anicyne changed the title Apply BEM refactoring to tree, tree-item, version, toolbar and tooltip Apply BEM refactoring to tree, tree-item, toolbar and tooltip Dec 12, 2024
@anicyne anicyne force-pushed the 7036-BEM-Refactoring-tree-treeItem-Version-tooltip-toolbar branch from b915d74 to 50e8326 Compare December 12, 2024 15:12
@anicyne
Merge branch 'develop' of https://github.com/public-ui/kolibri into 7…
f5b9370 
…036-BEM-Refactoring-tree-treeItem-Version-tooltip-toolbar
@anicyne anicyne requested a review from sdvg December 12, 2024 15:14
@anicyne anicyne force-pushed the 7036-BEM-Refactoring-tree-treeItem-Version-tooltip-toolbar branch from 739508a to 67e3a9d Compare December 16, 2024 07:11
sdvg
sdvg requested changes Dec 16, 2024
View reviewed changes
Copy link
Member

@sdvg sdvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noch offen: #7161 (comment)

@anicyne anicyne requested a review from sdvg December 16, 2024 12:50
@sdvg sdvg merged commit d37732f into develop Dec 16, 2024
9 checks passed
@sdvg sdvg deleted the 7036-BEM-Refactoring-tree-treeItem-Version-tooltip-toolbar branch December 16, 2024 13:24
@github-actions github-actions bot locked and limited conversation to collaborators Dec 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sdvg sdvg sdvg approved these changes

Assignees
No one assigned
Labels
v3 Here are issues that need to be resolved for version 3.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BEM-Refactoring
3 participants
@anicyne @sdvg @deleonio