Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply BEM refactor for Modal #7200

Merged
merged 2 commits into from
Dec 16, 2024
Merged

Apply BEM refactor for Modal #7200

merged 2 commits into from
Dec 16, 2024

Conversation

AlexanderSchmidtCE
Copy link
Contributor

@AlexanderSchmidtCE AlexanderSchmidtCE commented Dec 16, 2024 •
edited
Loading

Refs: #7036

The A11y and PO reviews will only take place after all other DoD steps have been completed by the Developer:

  • Meaningful pull request title for the release notes
  • Pull request is linked to an issue and all changes relate to the issue
  • Tests to protect this code implemented (if applicable)
  • Manual test performed successfully (if applicable)
  • Documentation or migration has been updated (if applicable)

@AlexanderSchmidtCE AlexanderSchmidtCE mentioned this pull request Dec 16, 2024
Open
55 tasks
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 16, 2024 •
edited
Loading

Netlify Draft Deployment
URL: https://6760357c32b0a04d8b4c2020--kolibri-public-ui.netlify.app
Logs: https://app.netlify.com/sites/kolibri-public-ui/deploys/6760357c32b0a04d8b4c2020

@sdvg sdvg marked this pull request as ready for review December 16, 2024 14:11
@sdvg sdvg merged commit 9b8864c into develop Dec 16, 2024
9 of 11 checks passed
@sdvg sdvg deleted the 7036-bem-refactor-modal branch December 16, 2024 14:23
@github-actions github-actions bot locked and limited conversation to collaborators Dec 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sdvg sdvg sdvg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexanderSchmidtCE @sdvg