Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply BEM refactor for table #7212

Merged
merged 34 commits into from
Dec 20, 2024
Merged

Apply BEM refactor for table #7212

merged 34 commits into from
Dec 20, 2024

Conversation

AlexanderSchmidtCE
Copy link
Contributor

@AlexanderSchmidtCE AlexanderSchmidtCE commented Dec 17, 2024 •
edited
Loading

Refs: #7036

The A11y and PO reviews will only take place after all other DoD steps have been completed by the Developer:

  • Meaningful pull request title for the release notes
  • Pull request is linked to an issue and all changes relate to the issue
  • Tests to protect this code implemented (if applicable)
  • Manual test performed successfully (if applicable)
  • Documentation or migration has been updated (if applicable)

@AlexanderSchmidtCE AlexanderSchmidtCE mentioned this pull request Dec 17, 2024
Open
55 tasks
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 17, 2024 •
edited
Loading

Netlify Draft Deployment
URL: https://676580becc099f91775c0598--kolibri-public-ui.netlify.app
Logs: https://app.netlify.com/sites/kolibri-public-ui/deploys/676580becc099f91775c0598

@AlexanderSchmidtCE AlexanderSchmidtCE marked this pull request as ready for review December 18, 2024 12:31
sdvg
sdvg reviewed Dec 19, 2024
View reviewed changes
packages/components/src/components/@shared/_kol-table-stateless-mixin.scss Outdated Show resolved Hide resolved
packages/components/src/components/@shared/_kol-table-stateless-mixin.scss Outdated Show resolved Hide resolved
packages/components/src/components/@shared/_kol-table-stateless-mixin.scss Outdated Show resolved Hide resolved
packages/components/src/components/@shared/_kol-table-stateless-mixin.scss Outdated Show resolved Hide resolved
packages/components/src/components/table-stateless/component.tsx Outdated Show resolved Hide resolved
packages/components/src/components/table-stateless/component.tsx Outdated Show resolved Hide resolved
packages/components/src/components/table-stateless/component.tsx Outdated Show resolved Hide resolved
@sdvg sdvg merged commit 0172d5f into develop Dec 20, 2024
9 checks passed
@sdvg sdvg deleted the 7036-bem-refactor-table branch December 20, 2024 14:52
@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sdvg sdvg sdvg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexanderSchmidtCE @sdvg