Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated properties from Modal, Toaster and Table components #7214

Merged
merged 8 commits into from
Dec 19, 2024

Conversation

sdvg
Copy link
Member

@sdvg sdvg commented Dec 18, 2024

The A11y and PO reviews will only take place after all other DoD steps have been completed by the Developer:

  • Meaningful pull request title for the release notes
  • Pull request is linked to an issue and all changes relate to the issue
  • Tests to protect this code implemented (if applicable)
  • Manual test performed successfully (if applicable)
  • Documentation or migration has been updated (if applicable)

sdvg added 2 commits December 18, 2024 09:19
…c-ui/kolibri into 7015-remove-deprecated-rest

* '7015-remove-deprecated-error-alert' of github.com:public-ui/kolibri:
  Document breaking changes
  Remove deprecated properties alert and error from all input components
  Remove deprecated property alert from combobox
Copy link
Contributor

github-actions bot commented Dec 18, 2024

sdvg added 5 commits December 18, 2024 10:27
…ve-deprecated-rest

* 'develop' of github.com:public-ui/kolibri:
  Fix typo
…ve-deprecated-rest

* 'develop' of github.com:public-ui/kolibri: (75 commits)
  Make value prop optional because of KolInputFile
  Remove _file reflection
  Fix faulty conflict resolution
  Refactor tests slightly and add remaining tests for DOM event details
  Add table breaking changes
  Add DOM even tests for input-file
  Document breaking change
  Consolidate event and callback testing
  Fix value check for onInput and onValue
  Remove/refactor other stopPropagation calls
  Remove stopPropagation helper
  Tweak test
  Add details to DOM events
  Minor refactoring
  Fix Enum name
  Fix E2E tests for DOM events
  Rename Enum Events to Callbacks to avoid confusion with KolCallbacks
  Fix custom events for table selection
  Introduce enum KolEvent, change DOM events to type CustomEvent with `kol`-prefix
  Fix input checkbox associated form field reflection
  ...
@sdvg sdvg changed the title 7015 remove deprecated rest Remove deprecated properties from Modal, Toaster and Table components Dec 19, 2024
@sdvg sdvg linked an issue Dec 19, 2024 that may be closed by this pull request
12 tasks
@sdvg sdvg marked this pull request as ready for review December 19, 2024 12:00
@sdvg sdvg mentioned this pull request Dec 19, 2024
12 tasks
deleonio
deleonio previously approved these changes Dec 19, 2024
@sdvg sdvg requested a review from deleonio December 19, 2024 15:15
@deleonio deleonio merged commit eebffe0 into develop Dec 19, 2024
9 checks passed
@deleonio deleonio deleted the 7015-remove-deprecated-rest branch December 19, 2024 16:54
@github-actions github-actions bot locked and limited conversation to collaborators Dec 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecated Features entfernen
2 participants