-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace the app files atomically and docker stop first before starting up for succeeding commits #70
Open
asakapab0i
wants to merge
31
commits into
pullpreview:master
Choose a base branch
from
asakapab0i:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Replace the app files atomically and docker stop first before starting up for succeeding commits #70
Changes from 12 commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
5f0bf1f
replace files atomically
asakapab0i 2cb4920
Merge pull request #1 from asakapab0i/bb-atomically-replace-the-app-f…
asakapab0i d96505f
create folder and ignore missing folder when deleting
asakapab0i 7f82c7e
sudo
asakapab0i de9ea53
rename instead of mv
asakapab0i da9e3eb
fix symlink
asakapab0i b0a64ce
debug app path
asakapab0i 558eb7a
restart when every succeeding commits
asakapab0i f524aca
comments and log messages
asakapab0i 0a66a8b
delete the app folder it will be a symlink
asakapab0i ee817be
docker restart does not load the updates
asakapab0i 2f73b20
remove default port in the url, it messes up csp policy
asakapab0i 6c8400d
add lightsail dns zone support
asakapab0i e4ec549
uniform naming
asakapab0i 391eadf
subdomain and create the subdomain early in the process
asakapab0i 78556d2
before instantiation
asakapab0i fa3b99c
remove subdomain
asakapab0i 1f38ae2
delete before terminating the instance
asakapab0i df863d7
debug info
asakapab0i eabb077
terminate instance requires a few more opts
asakapab0i e170a5e
terminate instance requires a few more opts
asakapab0i 4b91b44
fix delete domain
asakapab0i becaa1f
add more parameter in down calss
asakapab0i d40340b
add more parameter in down calss
asakapab0i ca89df5
fix tags
asakapab0i b8197fd
call launch
asakapab0i 1cfc063
restore target
asakapab0i 4901e9b
Merge pull request #2 from asakapab0i/bb-add-dns-zone-support
asakapab0i dec8c84
add trycatch on create and delete domain
asakapab0i d74da51
generic error catch
asakapab0i 75bdfd6
Merge pull request #3 from asakapab0i/bb-try-catch-create-delete-domain
asakapab0i File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
default_port should be kept if different than a standard port, but yes can be removed if 443 or 80