Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PULP-243] Bump ruby openapi-generator for core>=3.70 #108

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

pedro-psb
Copy link
Member

@pedro-psb pedro-psb commented Jan 6, 2025

Replaces: #101

Summary:

  • Dependency errors: added faraday and faraday_http constraints. That's due to katello lowerbound ruby version (>=2.7) for the lower version supported on Pulp's matrix.
  • Pathname (NameError): added require "pathname" in the api_client. The code was using this class/module (?) which was not being required (imported?) (ref). Didnt find similar cases in openapi-generator, so it's probably related to the restricted version set above.

@pedro-psb
Copy link
Member Author

pedro-psb commented Jan 7, 2025

The CI is passing but it is not using nighly pulp (the pulp-ci-centos image is stable), so its not really testing the >=3.70 branch. Locally I'm hitting some ruby errors:

[2025-01-07T09:30:12.339682 #1444741] DEBUG -- : Calling API: UploadsApi.update ...
Traceback (most recent call last):
        20: from test_bindings.rb:102:in `<main>'
        19: from test_bindings.rb:72:in `upload_file_in_chunks'
        18: from test_bindings.rb:72:in `open'
        17: from test_bindings.rb:88:in `block in upload_file_in_chunks'

...

/tmp/ruby-venv/local/gems/gems/pulpcore_client-3.70.0.dev0/lib/pulpcore_client/api_client.rb:144:in
`block in build_request_body': uninitialized constant PulpcoreClient::ApiClient::Pathname (NameError)

@pedro-psb pedro-psb changed the title Bump ruby openapi-generator for core>=3.70 [PULP-243] Bump ruby openapi-generator for core>=3.70 Jan 7, 2025
@pedro-psb pedro-psb marked this pull request as ready for review January 8, 2025 12:43
Copy link
Member

@mdellweg mdellweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is exactly the way I expect the bindings to be patched.
I cannot say much about the actual changes in the ruby code.

@ggainey ggainey merged commit 606967a into pulp:main Jan 8, 2025
4 checks passed
@pedro-psb pedro-psb deleted the bump-ruby-image branch January 8, 2025 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants