Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change despike settings #338

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Change despike settings #338

merged 1 commit into from
Dec 5, 2024

Conversation

svank
Copy link
Contributor

@svank svank commented Dec 4, 2024

PR summary

Is this how you change the despike settings that Prefect uses?

I ran /d0/punchsoc/gamera_data/0/PM2/2024/12/29/PUNCH_L0_PM2_20241229023210_v1.fits through despiking with these settings and it's catching like the center pixel of the brightest stars but otherwise it seems to be flagging streaks but not stars.

I need to leave now so I can't check it with any CR, PP, or PZ images, but this is here if you want to cross your fingers and run it overnight.

Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.30%. Comparing base (8552bb6) to head (5432b1b).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #338   +/-   ##
=======================================
  Coverage   86.30%   86.30%           
=======================================
  Files          56       56           
  Lines        3789     3789           
=======================================
  Hits         3270     3270           
  Misses        519      519           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@svank svank force-pushed the stars-arent-streaks branch from 6c3a6c4 to 5432b1b Compare December 4, 2024 23:53
@svank
Copy link
Contributor Author

svank commented Dec 5, 2024

OK, this has been tested with PZ, PM and PP, and might be fine for CR if not for PSF artifacts.

@jmbhughes jmbhughes self-requested a review December 5, 2024 09:09
@jmbhughes jmbhughes merged commit 544b039 into main Dec 5, 2024
7 of 8 checks passed
@jmbhughes jmbhughes deleted the stars-arent-streaks branch December 5, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants